Skip to content

Migrate org.eclipse.tm.terminal.connector.process#1970

Merged
laeubi merged 1 commit intoeclipse-platform:masterfrom
laeubi:migrate_connector_process
Jun 18, 2025
Merged

Migrate org.eclipse.tm.terminal.connector.process#1970
laeubi merged 1 commit intoeclipse-platform:masterfrom
laeubi:migrate_connector_process

Conversation

@laeubi
Copy link
Contributor

@laeubi laeubi commented Jun 18, 2025

Migrated from

https://github.com/eclipse-cdt/cdt/tree/main/terminal/plugins/org.eclipse.tm.terminal.connector.process

at commit 2ba5b3d68a373e3aa301fa50ec48a3a77d92a2ad

FYI @jonahgraham

This is required for the local connector what itself should be migrated to make this feature standalone usable. Currently using the Terminal View (and also the new #1969 ) will result in a message that no connector is available. While one can install them from the CDT site it is quite inconvenient, so it is the next logical step to bring them over here.

@laeubi
Copy link
Contributor Author

laeubi commented Jun 18, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

Test Results

 1 893 files  ±0   1 893 suites  ±0   1h 33m 4s ⏱️ - 2m 21s
 4 381 tests ±0   4 357 ✅ ±0   24 💤 ±0  0 ❌ ±0 
13 143 runs  ±0  12 976 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 6320f26. ± Comparison against base commit 3100182.

♻️ This comment has been updated with latest results.

@jonahgraham
Copy link
Contributor

This LGTM - but I assume there is some cleanup like you had to do on the last one because of Javadoc/etc errors.

@laeubi laeubi force-pushed the migrate_connector_process branch from dc4b556 to 6320f26 Compare June 18, 2025 17:41
@laeubi laeubi merged commit 47871af into eclipse-platform:master Jun 18, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants