Skip to content
This repository has been archived by the owner on Feb 22, 2020. It is now read-only.

Make LuceneSailConnection to replace query patterns with results inplace #255

Merged

Conversation

KMax
Copy link
Contributor

@KMax KMax commented Jun 23, 2019

Signed-off-by: Maxim Kolchin kolchinmax@gmail.com

This PR addresses GitHub issue: eclipse-rdf4j/rdf4j#1229.

Briefly describe the changes proposed in this PR:

  • Remove from LuceneSailConnection the code responsible for the inclusion of the query results into the query in the form of BindingSetAssigment. Move this functionality to SearchQueryEvaluator subclasses.
  • SearchQueryEvaluator subclasses replace the query patterns with the results in place instead of "smart" replacement mechanism used in LuceneSailConnection before.
  • Add unit tests for the subclasses.

Signed-off-by: Maxim Kolchin <kolchinmax@gmail.com>
@hmottestad
Copy link
Contributor

@rdf4j-bot run tests

@abrokenjester abrokenjester merged commit f862f99 into eclipse-rdf4j:develop Jun 30, 2019
abrokenjester pushed a commit that referenced this pull request Jun 30, 2019
Make LuceneSailConnection to replace query patterns with results inplace
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants