Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use try-with-resources #1092

Closed
barthanssens opened this issue Oct 5, 2018 · 1 comment
Closed

Use try-with-resources #1092

barthanssens opened this issue Oct 5, 2018 · 1 comment
Assignees
@barthanssens
Labels
📶 enhancement issue is a new feature or improvement M1 Fixed in milestone 1
Milestone
2.5.0

Comments

@barthanssens
Copy link
Contributor

In e.g. RDFJ util, there are quite a few try-finally blocks that can be replaced by the newer try-with-resources (saves a few lines of code and reduces resource leaks)
@barthanssens barthanssens self-assigned this Oct 5, 2018
@barthanssens barthanssens added the 📶 enhancement issue is a new feature or improvement label Oct 5, 2018
@barthanssens barthanssens mentioned this issue Oct 5, 2018
Merged
@abrokenjester abrokenjester modified the milestones: 2.4.1, 2.5.0 Oct 7, 2018
@barthanssens
Copy link
Contributor Author

See also #790

barthanssens added a commit that referenced this issue Oct 19, 2018
@barthanssens
Merge pull request #1094 from Fedict/issues/#1092-try-with-resources
1bab886 
Use try-with-resources
This was referenced Oct 19, 2018
Merged
Merged
Merged
@abrokenjester abrokenjester added the M1 Fixed in milestone 1 label Feb 21, 2019
abrokenjester pushed a commit that referenced this issue Aug 22, 2019
@barthanssens
Merge pull request #81 from Fedict/issues/#1092-try-with-resources
9d44e74 
Changed try-finally to try-with-resources
abrokenjester pushed a commit that referenced this issue Aug 22, 2019
@barthanssens
Merge pull request #116 from Fedict/issues/#1092-try-with-resources
9ef4d68 
Changed try-finally to try-with-resources
abrokenjester pushed a commit that referenced this issue Aug 22, 2019
@barthanssens
Merge pull request #117 from Fedict/issues/#1092-try-with-resources
f004651 
Partial rollback: try-with-resources fails on generic exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barthanssens barthanssens

Labels
📶 enhancement issue is a new feature or improvement M1 Fixed in milestone 1
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
2 participants
@abrokenjester @barthanssens