Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated URI in SPIN EvalFunction #1135

Closed
barthanssens opened this issue Oct 22, 2018 · 3 comments · Fixed by #2292
Closed

Deprecated URI in SPIN EvalFunction #1135

barthanssens opened this issue Oct 22, 2018 · 3 comments · Fixed by #2292
Assignees
@navdhaagarwal
Labels
📶 enhancement issue is a new feature or improvement good first issue issue is a good choice for getting started as an rdf4j contributor M1 Fixed in milestone 1
Milestone
3.3.0

Comments

@barthanssens
Copy link
Contributor

In org.eclipse.rdf4j.spin.function.EvalFunction, the deprecated URI is used instead of IRI in isQuery() and addArguments
@barthanssens barthanssens added 📶 enhancement issue is a new feature or improvement rdf4j-storage good first issue issue is a good choice for getting started as an rdf4j contributor labels Oct 22, 2018
navdhaagarwal pushed a commit to navdhaagarwal/rdf4j that referenced this issue May 27, 2020
eclipse-rdf4jGH-1135:replaced deprecated URI with IRI
7ac18a9 
Signed-off-by: navdhaagarwal <navdha16250@iiitd.ac.in>
@navdhaagarwal
Copy link
Contributor

Hi!
We (me and @shubhi0108) were working on this issue. As said, the functions isQuery() and addArguments() were using deprecated URI hence we have replaced then with IRI. Please guide us with what needs to be done further in this issue.

So far I have covered the legalities, forked the repository, created a new branch as per the guidelines and have committed the changes on that branch and verifying the existing testcases.

@navdhaagarwal navdhaagarwal mentioned this issue May 28, 2020
Merged
5 tasks
@barthanssens barthanssens added this to the 3.3.0 milestone May 28, 2020
abrokenjester pushed a commit that referenced this issue May 29, 2020
GH-1135:replaced deprecated URI with IRI (#2292)
787f086 
Signed-off-by: navdhaagarwal <navdha16250@iiitd.ac.in>
@barthanssens
Copy link
Contributor Author

Names have been added to the 3.3.0 release notes #2235

@navdhaagarwal
Copy link
Contributor

Thank you @barthanssens

@hmottestad hmottestad added the M1 Fixed in milestone 1 label Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@navdhaagarwal navdhaagarwal

Labels
📶 enhancement issue is a new feature or improvement good first issue issue is a good choice for getting started as an rdf4j contributor M1 Fixed in milestone 1
Projects
None yet
Milestone
3.3.0
Development

Successfully merging a pull request may close this issue.

GH-1135 replaced deprecated URI with IRI navdhaagarwal/rdf4j
4 participants
@abrokenjester @hmottestad @barthanssens @navdhaagarwal