Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SchemaCachingInferencer in default Sail stacks for Workbench and Console #1226

Closed
abrokenjester opened this issue Dec 26, 2018 · 1 comment
Closed

Use SchemaCachingInferencer in default Sail stacks for Workbench and Console #1226

abrokenjester opened this issue Dec 26, 2018 · 1 comment
Assignees
@abrokenjester
Labels
📦 console affects the RDF4J Console CLI 📶 enhancement issue is a new feature or improvement M1 Fixed in milestone 1 📦 workbench affects the RDF4J Workbench
Milestone
2.5.0

Comments

@abrokenjester
Copy link
Contributor

We should replace the use of the ForwardChainingInferencer in the sail stack templates for Workbench and Console with the new SchemaCachingInferencer.

This won't break existing code as existing repos with the old inferencer will continue to use that. Just newly created repos will switch to the new implementation.

Related: #1224
Related: #1225
@abrokenjester abrokenjester added 📶 enhancement issue is a new feature or improvement rdf4j-tools labels Dec 26, 2018
@abrokenjester abrokenjester added this to the 2.5.0 milestone Dec 26, 2018
@abrokenjester abrokenjester added the 📦 console affects the RDF4J Console CLI label Dec 26, 2018
@barthanssens barthanssens added the 📦 workbench affects the RDF4J Workbench label Dec 28, 2018
@abrokenjester
Copy link
Contributor Author

As part of this we should add a SchemaCachingRDFSInferencerConfig and ...Factory class in org.eclipse.rdf4j.sail.inferencer.fc.config.

@abrokenjester abrokenjester self-assigned this Jan 5, 2019
abrokenjester added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Jan 5, 2019
@abrokenjester
eclipse-rdf4j/rdf4j#1226 SPI/Factory for Schema Caching Inferencer
1a082f5 
Signed-off-by: Jeen Broekstra <jeen.broekstra@gmail.com>
abrokenjester added a commit that referenced this issue Jan 5, 2019
@abrokenjester
GH-1226 add config template for SC-inferencer [WIP]
3458e57 
Signed-off-by: Jeen Broekstra <jeen.broekstra@gmail.com>
@abrokenjester abrokenjester mentioned this issue Jan 5, 2019
Closed
abrokenjester added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Jan 7, 2019
@abrokenjester
eclipse-rdf4j/rdf4j#1226 added isolation level compliance tests for i…
11bafb7 
…nferencer

Signed-off-by: Jeen Broekstra <jeen.broekstra@gmail.com>
abrokenjester added a commit that referenced this issue Jan 8, 2019
@abrokenjester
#1226 all templates now use new inferencer
05179f8 
Signed-off-by: Jeen Broekstra <jeen.broekstra@gmail.com>
This was referenced Jan 10, 2019
Merged
Merged
abrokenjester pushed a commit that referenced this issue Jan 11, 2019
Merge pull request #1241 from eclipse/issues/GH-1226-server-inferencer
fd7b31c 
Use SchemaCachingInferencer as default in config templates
@abrokenjester abrokenjester added the M1 Fixed in milestone 1 label Feb 21, 2019
abrokenjester pushed a commit that referenced this issue Aug 22, 2019
Merge pull request #144 from eclipse/issues/GH-1226-server-inferencer
7b39a41 
SchemaCachingInferencer as the default RDFS reasoner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abrokenjester abrokenjester

Labels
📦 console affects the RDF4J Console CLI 📶 enhancement issue is a new feature or improvement M1 Fixed in milestone 1 📦 workbench affects the RDF4J Workbench
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
2 participants
@abrokenjester @barthanssens