Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHACL - Revalidate already added data #1290

Closed
hmottestad opened this issue Feb 10, 2019 · 1 comment
Closed

SHACL - Revalidate already added data #1290

hmottestad opened this issue Feb 10, 2019 · 1 comment
Assignees
@hmottestad
Labels
M1 Fixed in milestone 1 📝 Needs documentation Issue requires updates to the project documentation 📦 SHACL affects the SHACL validator
Milestone
3.0.0

Comments

@hmottestad
Copy link
Contributor

hmottestad commented Feb 10, 2019 •
edited
Loading

To support modifying shapes after data has been added we need to be able to revalidate all previously added data.

Only shapes that have been modified need to be executed.
@hmottestad hmottestad added the 📦 SHACL affects the SHACL validator label Feb 10, 2019
@hmottestad hmottestad added this to the 3.0 milestone Feb 10, 2019
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 23, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 created test
93b7588 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 23, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 buggy implementation
18ab1da 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 23, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 fixed an incorrect join
1106ef0 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 23, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 correct but inefficient implementation
5f971c8 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 23, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 better cache handling
37b283f 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
@hmottestad hmottestad mentioned this issue Mar 23, 2019
Merged
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 23, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 check for active transaction
c76f49f 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
@hmottestad hmottestad self-assigned this Mar 23, 2019
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 24, 2019
@hmottestad
Merge branch 'develop' into feature/101_shacl_w3c_tests
a0309b9 
* develop:
  more tests
  formatter
  created a helpful tips section for the github PR template
  eclipse-rdf4j/rdf4j#1358 added support for sh:in
  eclipse-rdf4j/rdf4j#1290 check for active transaction
  eclipse-rdf4j/rdf4j#1290 better cache handling
  eclipse-rdf4j/rdf4j#1290 correct but  inefficient implementation
  eclipse-rdf4j/rdf4j#1290 created test

Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 26, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 tests
942ac2c 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 26, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 initial implementation
b699ee8 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 26, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 handle concurrency better
1fc42b4 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
@hmottestad hmottestad mentioned this issue Mar 26, 2019
Merged
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 26, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 locking and isolation
b66fa63 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 26, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 locking and isolation
f8eef23 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 30, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 deadlock detection
c309fe1 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 30, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 deadlock detection
70a3ae2 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 30, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 detect deadlock when modifying shapes in sin…
20d4cf7 
…gle thread from multiple connections

Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 31, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 multithreaded test
61a121d 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 31, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 added benchmakr
407d4d8 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 31, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 fixed typo and reformat
378b505 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
@hmottestad
Copy link
Contributor Author

hmottestad commented Mar 31, 2019 •
edited
Loading

Tasks left:

  • Only shapes that have been modified need to be executed
  • Documentation

hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 31, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 diff shapes and implement equals/hashcode
4686800 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
@hmottestad hmottestad mentioned this issue Mar 31, 2019
Merged
@hmottestad hmottestad added website / documentation Website update / Documentation issue 📝 Needs documentation Issue requires updates to the project documentation and removed website / documentation Website update / Documentation issue labels Mar 31, 2019
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 3, 2019
@hmottestad
Merge branch 'develop' into issues/1350_shacl_new_memory_store
6ff1315 
* develop: (35 commits)
  fixes eclipse-rdf4j/rdf4j#1377 and fixes eclipse-rdf4j/rdf4j#1376
  eclipse-rdf4j/rdf4j#1290 diff shapes and implement equals/hashcode
  eclipse-rdf4j/rdf4j#1374 log unsupported shacl features with test
  eclipse-rdf4j/rdf4j#1290 fixed typo and reformat
  eclipse-rdf4j/rdf4j#1290 added benchmakr
  eclipse-rdf4j/rdf4j#1290 multithreaded test
  eclipse-rdf4j/rdf4j#1290 detect deadlock when modifying shapes in single thread from multiple connections
  eclipse-rdf4j/rdf4j#1290 deadlock detection
  cleanup
  #211 read/write lock
  formatter
  eclipse-rdf4j/rdf4j#1290 locking and isolation
  formatter
  eclipse-rdf4j/rdf4j#1290 handle concurrency better
  eclipse-rdf4j/rdf4j#1290 initial implementation
  eclipse-rdf4j/rdf4j#1290 tests
  Use commons-lang3 and commons-text instead of commons-lang Signed-off-by:Bart Hanssens <bart.hanssens@bosa.fgov.be>
  eclipse-rdf4j/rdf4j#1362 normalised targets with SPARQL
  eclipse-rdf4j/rdf4j#1359 bug fix and benchmark
  eclipse-rdf4j/rdf4j#1359 some documentation
  ...

Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>

# Conflicts:
#	shacl/src/main/java/org/eclipse/rdf4j/sail/shacl/ShaclSailConnection.java
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 5, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 allow to read and delete shapes
d387f4c 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
@hmottestad hmottestad mentioned this issue Apr 5, 2019
Merged
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 6, 2019
@hmottestad
Merge branch 'develop' into issues/1375_bigger_benchmark
b91be6a 
* develop:
  eclipse-rdf4j/rdf4j#1384 bug fix
  eclipse-rdf4j/rdf4j#1384 optimize
  formatter
  faster uniqueLang on empty base sail
  eclipse-rdf4j/rdf4j#1384 test and fix
  don't activate quick profile on skipTests
  shacl tests use logback explicitly instead of slf4j-simple
  eclipse-rdf4j/rdf4j#1290 allow to read and delete shapes
  eclipse-rdf4j/rdf4j#1236 clean install succesful
  eclipse-rdf4j/rdf4j#1236 moved test suites for geosparql, serql, shacl, and sparql
  eclipse-rdf4j/rdf4j#1236 moved tests for shacl and spin
  eclipse-rdf4j/rdf4j#1236 moved store and lucene test suites
  eclipse-rdf4j/rdf4j#1236 cleanup
  eclipse-rdf4j/rdf4j#1236 migrating sailmodel compliance [wip]
  eclipse-rdf4j/rdf4j#1236 sail compliance tests to respective modules
  fixed formatting
  eclipse-rdf4j/rdf4j#1229 compliance tests for Lucene itself

Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>

# Conflicts:
#	shacl/src/main/java/org/eclipse/rdf4j/sail/shacl/ShaclSailConnection.java
hmottestad added a commit to eclipse-rdf4j/rdf4j-doc that referenced this issue Apr 12, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1290 updating shacl shapes and also validating la…
7ae650c 
…rge datasets

Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
@abrokenjester abrokenjester added the M1 Fixed in milestone 1 label Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmottestad hmottestad

Labels
M1 Fixed in milestone 1 📝 Needs documentation Issue requires updates to the project documentation 📦 SHACL affects the SHACL validator
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@abrokenjester @hmottestad