Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHACL - support sh:targetNode better #1574

Closed
hmottestad opened this issue Oct 1, 2019 · 0 comments · Fixed by #2020
Closed

SHACL - support sh:targetNode better #1574

hmottestad opened this issue Oct 1, 2019 · 0 comments · Fixed by #2020
Labels
🐞 bug issue is a bug 📦 SHACL affects the SHACL validator
Milestone
3.1.3

Comments

@hmottestad
Copy link
Contributor

Example:

ex:PersonShape
	a sh:NodeShape  ;
	sh:targetNode ex:validPerson ;
	sh:property [
		sh:path foaf:name;
		sh:minCount 1 ;

	] .

If ex:validPerson does not exist at all in the database, then it is invalid because it still does not have a foaf:name.
@hmottestad hmottestad added 📦 SHACL affects the SHACL validator 🐞 bug issue is a bug labels Oct 1, 2019
@hmottestad hmottestad added this to the 3.1.0 milestone Oct 1, 2019
@abrokenjester abrokenjester modified the milestones: 3.1.0, 3.1.1 Feb 3, 2020
@abrokenjester abrokenjester modified the milestones: 3.1.1, 3.1.2 Feb 27, 2020
@hmottestad hmottestad modified the milestones: 3.1.2, 3.2.0 Mar 11, 2020
hmottestad added a commit that referenced this issue Mar 18, 2020
@hmottestad
#1574 all tests pass now
99c8bb9 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Mar 18, 2020
@hmottestad
GH-1574 validate all target nodes for every transaction
e473e34 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Mar 18, 2020
@hmottestad
GH-1574 validate all target nodes for every transaction
1ab39f7 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Mar 18, 2020
@hmottestad
GH-1574 fixed some failing tests and added some edge case tests
a33baf4 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
@hmottestad hmottestad mentioned this issue Mar 18, 2020
Merged
@hmottestad hmottestad modified the milestones: 3.2.0, 3.1.3 Mar 18, 2020
hmottestad added a commit that referenced this issue Mar 19, 2020
@hmottestad
#1574 fixed failing W3C tests and created test to force use of TreeSet
4ecfb43 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Mar 19, 2020
@hmottestad
#1574 fixed failing W3C tests and created test to force use of TreeSet
2750f53 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Mar 19, 2020
@hmottestad
GH-1574 validate all target nodes for every transaction
ebe9d6e 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Mar 19, 2020
@hmottestad
GH-1574 fixed some failing tests and added some edge case tests
2663ff3 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Mar 19, 2020
@hmottestad
GH-1574 fixed failing W3C tests and created test to force use of TreeSet
0168b23 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Mar 20, 2020
@hmottestad
GH-1574 added comments to help next developer
56b302c 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Mar 20, 2020
@hmottestad
Merge pull request #2020 from eclipse/issues/1574_better_target_node_…
b4ee8b3 
…support fixes GH-1574

GH-1574 better target node support
@danaivach danaivach mentioned this issue Sep 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug issue is a bug 📦 SHACL affects the SHACL validator
Projects
None yet
Milestone
3.1.3
Development

Successfully merging a pull request may close this issue.

GH-1574 better target node support eclipse-rdf4j/rdf4j
2 participants
@abrokenjester @hmottestad