Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTripleParser uses deprecated setting internally #1841

Closed
barthanssens opened this issue Jan 18, 2020 · 1 comment
Closed

NTripleParser uses deprecated setting internally #1841

barthanssens opened this issue Jan 18, 2020 · 1 comment
Assignees
@barthanssens
Labels
📶 enhancement issue is a new feature or improvement M2 Fixed in milestone 2 ⛔ Not backwards compatible A change that breaks backwards compatibility and needs a major release 📦 rio affects the Rio RDF Parser/Writer toolkit 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks
Milestone
4.0.0

Comments

@barthanssens
Copy link
Contributor

barthanssens commented Jan 18, 2020 •
edited
Loading

Trivial change: NTripleParser and TrixParser still use deprecated NTriplesParserSettings.FAIL_ON_NTRIPLES_INVALID_LINES instead of FAIL_ON_INVALID_LINES
@barthanssens barthanssens added 📶 enhancement issue is a new feature or improvement 📦 rio affects the Rio RDF Parser/Writer toolkit labels Jan 18, 2020
@barthanssens barthanssens self-assigned this Jan 18, 2020
@barthanssens barthanssens added this to the 4.0.0 milestone Jan 20, 2020
@barthanssens barthanssens added the ⛔ Not backwards compatible A change that breaks backwards compatibility and needs a major release label Jan 20, 2020
@barthanssens
Copy link
Contributor Author

NTriplesParserSettings sets the deprecated setting to the value of the "new" setting.

So while it is possible to add a small extra check in e.g. parse to use the new setting instead of the old one, it's not worth the effort and it would be better to just make sure the old setting is removed altogether in a new major release.

@barthanssens barthanssens added the 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks label Aug 17, 2021
barthanssens added a commit to Fedict/rdf4j that referenced this issue Aug 17, 2021
@barthanssens
eclipse-rdf4jGH-1841: remove deprecated NTriples / Trix parser settings
66f3075 
Signed-off-by:Bart Hanssens <bart.hanssens@bosa.fgov.be>
barthanssens added a commit to Fedict/rdf4j that referenced this issue Aug 17, 2021
@barthanssens
eclipse-rdf4jGH-1841: remove deprecated NTriples / Trix parser settings
e6388b5 
Signed-off-by:Bart Hanssens <bart.hanssens@bosa.fgov.be>
@barthanssens barthanssens mentioned this issue Aug 17, 2021
Closed
5 tasks
barthanssens added a commit to Fedict/rdf4j that referenced this issue Aug 17, 2021
@barthanssens
eclipse-rdf4jGH-1841: remove deprecated NTriples / Trix parser settings
964b680 
Signed-off-by:Bart Hanssens <bart.hanssens@bosa.fgov.be>
barthanssens added a commit to Fedict/rdf4j that referenced this issue Aug 17, 2021
@barthanssens
Merge origin/eclipse-rdf4jGH-1841-ntripleparser-deprecated-settings i…
4489e30 
…nto eclipse-rdf4jGH-1841-ntripleparser-deprecated-settings
barthanssens added a commit to Fedict/rdf4j that referenced this issue Aug 17, 2021
@barthanssens
eclipse-rdf4jGH-1841: remove deprecated NTriples / Trix parser settings
92467b4 
Signed-off-by:Bart Hanssens <bart.hanssens@bosa.fgov.be>
barthanssens added a commit to Fedict/rdf4j that referenced this issue Dec 30, 2021
@barthanssens
eclipse-rdf4jGH-1841: remove deprecated NTriples / Trix parser settings
7b6cdce 
Signed-off-by:Bart Hanssens <bart.hanssens@bosa.fgov.be>
@barthanssens barthanssens mentioned this issue Dec 30, 2021
Merged
5 tasks
abrokenjester added a commit that referenced this issue Jan 5, 2022
@abrokenjester
Merge pull request #3562 from Fedict/GH-1841-ntripleparser-deprecated…
4f3cee4 
…-settings

GH-1841: remove deprecated NTriples / Trix parser settings
@barthanssens barthanssens mentioned this issue Jan 14, 2022
Closed
@abrokenjester abrokenjester added the M2 Fixed in milestone 2 label Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barthanssens barthanssens

Labels
📶 enhancement issue is a new feature or improvement M2 Fixed in milestone 2 ⛔ Not backwards compatible A change that breaks backwards compatibility and needs a major release 📦 rio affects the Rio RDF Parser/Writer toolkit 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@abrokenjester @barthanssens