-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SparqlProtocolSession uses this.getClass() as logger name #1970
Comments
aschwarte10
added a commit
to aschwarte10/rdf4j
that referenced
this issue
Mar 5, 2020
The SparqlProtocolSession uses this.getClass() as a name for the logger. When having an extension of the class, this leads to misleading log output. Particularly the logging levels are also harder to control (w.r.t namespacing and packaging). The general recommendation for logger names should be to use the class name, at least it should adhere to the rdf4j package structure.
abrokenjester
pushed a commit
that referenced
this issue
Mar 6, 2020
The SparqlProtocolSession uses this.getClass() as a name for the logger. When having an extension of the class, this leads to misleading log output. Particularly the logging levels are also harder to control (w.r.t namespacing and packaging). The general recommendation for logger names should be to use the class name, at least it should adhere to the rdf4j package structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The SparqlProtocolSession uses this.getClass() as a name for the logger.
In our application we have an extension of the class, which leads to misleading log output. Particularly the logging levels are also harder to control (w.r.t namespacing and packaging).
The general recommendation for logger names should be to use the class name, at least it should adhere to the rdf4j package structure.
The text was updated successfully, but these errors were encountered: