Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RIO: exclude jackson from api module #2199

Closed
barthanssens opened this issue May 7, 2020 · 2 comments
Closed

RIO: exclude jackson from api module #2199

barthanssens opened this issue May 7, 2020 · 2 comments
Assignees
@barthanssens
Labels
M1 Fixed in milestone 1 📝 Needs documentation Issue requires updates to the project documentation 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks
Milestone
3.3.0

Comments

@barthanssens
Copy link
Contributor

Rio API module has JSON-LD Java as a dependency (because the JSONLDSettings uses the DocumentLoader class), but this also drags in a few jackson jars, which aren't used.
Removing them should reduce size.
@barthanssens barthanssens added the 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks label May 7, 2020
@barthanssens barthanssens added this to the 3.3.0 milestone May 7, 2020
@barthanssens barthanssens self-assigned this May 7, 2020
barthanssens added a commit to Fedict/rdf4j that referenced this issue May 7, 2020
@barthanssens
eclipse-rdf4jGH-2199 exclude jackson dependencies from POM
1e68288 
Signed-off-by:Bart Hanssens <bart.hanssens@bosa.fgov.be>
@barthanssens barthanssens mentioned this issue May 7, 2020
Merged
4 tasks
barthanssens added a commit to Fedict/rdf4j that referenced this issue May 7, 2020
@barthanssens
eclipse-rdf4jGH-2199 added jackson dependencies to query POM
30be999 
Signed-off-by:Bart Hanssens <bart.hanssens@bosa.fgov.be>
@barthanssens barthanssens modified the milestones: 3.3.0, 4.0.0 May 7, 2020
@barthanssens barthanssens added the ⛔ Not backwards compatible A change that breaks backwards compatibility and needs a major release label May 7, 2020
@barthanssens
Copy link
Contributor Author

Labeling it as not-backwards compatible, because some projects may rely on the implicitly imported jackson dependencies

@barthanssens barthanssens modified the milestones: 4.0.0, 3.3.0 May 18, 2020
@barthanssens
Copy link
Contributor Author

As discusses in PR: move to 3.3.0, but don't forget to include a comment in release notes #2235

@barthanssens barthanssens removed the ⛔ Not backwards compatible A change that breaks backwards compatibility and needs a major release label May 18, 2020
@barthanssens barthanssens added the 📝 Needs documentation Issue requires updates to the project documentation label May 20, 2020
barthanssens added a commit to Fedict/rdf4j that referenced this issue May 28, 2020
@barthanssens
eclipse-rdf4jGH-2199 exclude jackson dependencies from POM
dc2713c 
Signed-off-by:Bart Hanssens <bart.hanssens@bosa.fgov.be>
barthanssens added a commit to Fedict/rdf4j that referenced this issue May 28, 2020
@barthanssens
eclipse-rdf4jGH-2199 formatting
c9845b9 
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
barthanssens added a commit to Fedict/rdf4j that referenced this issue May 28, 2020
@barthanssens
eclipse-rdf4jGH-2199 exclude jackson dependencies from POM
dc9c65e 
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
barthanssens added a commit that referenced this issue May 28, 2020
@barthanssens
GH-2199 exclude jackson dependencies from POM (#2200)
1d17aa6 
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
@hmottestad hmottestad added the M1 Fixed in milestone 1 label Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barthanssens barthanssens

Labels
M1 Fixed in milestone 1 📝 Needs documentation Issue requires updates to the project documentation 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
2 participants
@hmottestad @barthanssens