Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache the MemStatementIterator instances if they are particularly costly #3523

Closed
hmottestad opened this issue Dec 17, 2021 · 0 comments · Fixed by #3524
Closed

Cache the MemStatementIterator instances if they are particularly costly #3523

hmottestad opened this issue Dec 17, 2021 · 0 comments · Fixed by #3524
Assignees
@hmottestad
Labels
📶 enhancement issue is a new feature or improvement M2 Fixed in milestone 2 ⏩ performance
Milestone
4.0.0

Comments

@hmottestad
Copy link
Contributor

Problem description

MemStatementIterator use a statement list which consists of all possibly matching statements from the smallest list from the index. Sometimes the indexes aren't as efficient as we hope and there are a lot of statements to check with few matching statements.

Preferred solution

A cache that caches costly MemStatementIterator that are frequently used.

Are you interested in contributing a solution yourself?

Yes

Alternatives you've considered

No response

Anything else?

No response
@hmottestad hmottestad added the 📶 enhancement issue is a new feature or improvement label Dec 17, 2021
hmottestad added a commit that referenced this issue Dec 17, 2021
@hmottestad
GH-3523 implement a cache mechanism for MemStatementIterator(s)
50f0b04 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
@hmottestad hmottestad mentioned this issue Dec 17, 2021
Merged
5 tasks
hmottestad added a commit that referenced this issue Dec 17, 2021
@hmottestad
GH-3523 close iterator, higher cost required before considering cachi…
7ed2d32 
…ng, less work when invalidating the cache and also some other fixes

Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Dec 18, 2021
@hmottestad
GH-3523 implement a cache mechanism for MemStatementIterator(s)
bcc9fe8 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Dec 18, 2021
@hmottestad
GH-3523 close iterator, higher cost required before considering cachi…
976669d 
…ng, less work when invalidating the cache and also some other fixes

Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
@abrokenjester abrokenjester linked a pull request Dec 19, 2021 that will close this issue
GH-3523 Cache mechanism for MemStatementIterator(s) #3524
Merged
5 tasks
hmottestad added a commit that referenced this issue Dec 22, 2021
@hmottestad
GH-3523 implement a cache mechanism for MemStatementIterator(s)
3000d96 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Dec 22, 2021
@hmottestad
GH-3523 close iterator, higher cost required before considering cachi…
84374ab 
…ng, less work when invalidating the cache and also some other fixes

Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 5, 2022
@hmottestad
GH-3523 implement a cache mechanism for MemStatementIterator(s)
49d8e79 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 5, 2022
@hmottestad
GH-3523 close iterator, higher cost required before considering cachi…
78d9390 
…ng, less work when invalidating the cache and also some other fixes

Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 5, 2022
@hmottestad
GH-3523 rewrite code
4a5ff66 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 5, 2022
@hmottestad
GH-3523 rewrite code
0dda66f 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 7, 2022
@hmottestad
GH-3523 Cache mechanism for MemStatementIterator(s) (#3524)
50c56f3 
GH-3523 implement a cache mechanism for MemStatementIterator(s)

Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
@hmottestad hmottestad added this to the 4.0.0 milestone Jan 7, 2022
@abrokenjester abrokenjester added the M2 Fixed in milestone 2 label Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmottestad hmottestad

Labels
📶 enhancement issue is a new feature or improvement M2 Fixed in milestone 2 ⏩ performance
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

GH-3523 Cache mechanism for MemStatementIterator(s) eclipse-rdf4j/rdf4j
3 participants
@abrokenjester @hmottestad @barthanssens