Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concurrent WeakObjectRegistry #3572

Closed
hmottestad opened this issue Jan 5, 2022 · 2 comments · Fixed by #3573
Closed

Concurrent WeakObjectRegistry #3572

hmottestad opened this issue Jan 5, 2022 · 2 comments · Fixed by #3573
Assignees
@hmottestad
Labels
📶 enhancement issue is a new feature or improvement M2 Fixed in milestone 2 ⏩ performance
Milestone
4.0.0

Comments

@hmottestad
Copy link
Contributor

Problem description

Performance of the MemValueFactory is poor when there are multiple threads performing read operations because the WeakObjectRegistry does not support any concurrency.

Preferred solution

No response

Are you interested in contributing a solution yourself?

Yes

Alternatives you've considered

No response

Anything else?

No response
@hmottestad hmottestad added the 📶 enhancement issue is a new feature or improvement label Jan 5, 2022
@hmottestad
Copy link
Contributor Author

Could not get the following to work correctly: https://docs.spring.io/spring-framework/docs/4.0.0.M1_to_4.2.0.M2/Spring%20Framework%204.2.0.M2/org/springframework/util/ConcurrentReferenceHashMap.html

hmottestad added a commit that referenced this issue Jan 5, 2022
@hmottestad
GH-3572 benchmark and test
82cf2b4
hmottestad added a commit that referenced this issue Jan 5, 2022
@hmottestad
GH-3572 allow concurrent reads and writes against the WeakObjectRegistry
8bbd676 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 5, 2022
@hmottestad
GH-3572 benchmark and test
986fe34
hmottestad added a commit that referenced this issue Jan 5, 2022
@hmottestad
GH-3572 allow concurrent reads and writes against the WeakObjectRegistry
f3deb06 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 5, 2022
@hmottestad
GH-3572 benchmark and test
dcbceaa
hmottestad added a commit that referenced this issue Jan 5, 2022
@hmottestad
GH-3572 allow concurrent reads and writes against the WeakObjectRegistry
69650d6 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 6, 2022
@hmottestad
GH-3572 benchmark and test
57649ec 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 6, 2022
@hmottestad
GH-3572 allow concurrent reads and writes against the WeakObjectRegistry
f9ba719 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 6, 2022
@hmottestad
GH-3572 allow concurrent reads and writes against the WeakObjectRegistry
c88cd08 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
@hmottestad hmottestad mentioned this issue Jan 6, 2022
Merged
5 tasks
hmottestad added a commit that referenced this issue Jan 7, 2022
@hmottestad
GH-3572 fix null pointer bug and revert tests
5d691a8 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 7, 2022
@hmottestad
GH-3572 allow concurrent reads and writes against the WeakObjectRegistry
1630710 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 7, 2022
@hmottestad
GH-3572 benchmark and test
afd8b18 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 7, 2022
@hmottestad
GH-3572 allow concurrent reads and writes against the WeakObjectRegistry
44809fd 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 7, 2022
@hmottestad
GH-3572 allow concurrent reads and writes against the WeakObjectRegistry
f717f88 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
@abrokenjester abrokenjester added this to the 4.0.0 milestone Jan 8, 2022
@abrokenjester abrokenjester linked a pull request Jan 8, 2022 that will close this issue
GH-3572 Concurrent WeakObjectRegistry #3573
Merged
5 tasks
@hmottestad
Copy link
Contributor Author

Related to #3435

hmottestad added a commit that referenced this issue Jan 10, 2022
@hmottestad
GH-3572 benchmark and test
4271383 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 10, 2022
@hmottestad
GH-3572 allow concurrent reads and writes against the WeakObjectRegistry
3efbe1f 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 11, 2022
@hmottestad
GH-3572 benchmark and test
73bdb75 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 11, 2022
@hmottestad
GH-3572 allow concurrent reads and writes against the WeakObjectRegistry
31eae61 
Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
hmottestad added a commit that referenced this issue Jan 11, 2022
@hmottestad
Merge pull request #3573 from eclipse/GH-3572-concurreny-weak-object-…
bf89717 
…registry

GH-3572 Concurrent WeakObjectRegistry
@abrokenjester abrokenjester added the M2 Fixed in milestone 2 label Jan 23, 2022
@abrokenjester abrokenjester mentioned this issue May 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmottestad hmottestad

Labels
📶 enhancement issue is a new feature or improvement M2 Fixed in milestone 2 ⏩ performance
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

GH-3572 Concurrent WeakObjectRegistry eclipse-rdf4j/rdf4j
2 participants
@abrokenjester @hmottestad