-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document step-by-step procedure for creating docker images and publishing them as part of release #3768
Comments
Yeah, I'll have to update and improve the outdated docs on https://rdf4j.org/documentation/developer/releases/#optional-publishing-docker-images |
Oh, I hadn't even seen that! I was looking at the Readme.dev in |
Hmz yes, some cleanup is needed :-) And perhaps having (another) look at the procedure since support for multiple platforms is easier / more common than it used to be |
Modern approach to do multi-arch builds: https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide and https://www.docker.com/blog/multi-platform-docker-builds/ |
So instead of manually creating separate tags per architecture, this can "now" (well, since quite a while) be handled automatically by docker / hub.docker itself. So one can just go to the directory containing the Dockerfile and do
This requires that the base image being used is available for these platforms, but for RDF4J this should not be a problem (basic tomcat image is available for amd64 and arm64) What also can be handled in 1 single Dockerfile (instead of requiring a shell script) is building the project in a "first stage" (either do a complete build via mvn, or just download the zip from the rdf4j website) , then copying the result to the second stage using |
For automation, this action might be useful: https://github.com/docker/build-push-action |
I think this one can be closed, see also #4243 |
The process to create docker images for different architectures and to publish them to dockerhub as part of the release process is poorly documented. As a result we tend to forget to do this.
The text was updated successfully, but these errors were encountered: