Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public API methods incorrectly marked deprecated #4065

Closed
abrokenjester opened this issue Jul 17, 2022 · 1 comment · Fixed by #4067
Closed

public API methods incorrectly marked deprecated #4065

abrokenjester opened this issue Jul 17, 2022 · 1 comment · Fixed by #4067
Assignees
@abrokenjester
Labels
🐞 bug issue is a bug
Milestone
4.1.0

Comments

@abrokenjester
Copy link
Contributor

abrokenjester commented Jul 17, 2022 •
edited
Loading

Several public API methods, for example in the QueryResult interface as well as QueryResults utility methods are marked deprecated incorrectly. Looks like this happened because of the deprecation of a lot of code related to Iterations.

This leads to deprecation warnings in user code that really shouldn't happen. I suggest we do a bit of a cleanup, overriding such methods where necessary.
@abrokenjester abrokenjester added the 🐞 bug issue is a bug label Jul 17, 2022
@abrokenjester abrokenjester added this to the 4.1.0 milestone Jul 17, 2022
@abrokenjester abrokenjester changed the title QueryResults methods incorrectly marked deprecated public API methods incorrectly marked deprecated Jul 17, 2022
@abrokenjester
Copy link
Contributor Author

@hmottestad just making you aware this is an issue that we probably want to fix before releasing 4.1.0.

@abrokenjester abrokenjester self-assigned this Jul 17, 2022
abrokenjester added a commit that referenced this issue Jul 18, 2022
@abrokenjester
GH-4065 make QueryResult interface declare public methods directly
d5c53ee
abrokenjester added a commit that referenced this issue Jul 18, 2022
@abrokenjester
GH-4065 define public api to avoid incorrect deprecation messages
f1dd9ef
@abrokenjester abrokenjester mentioned this issue Jul 18, 2022
Merged
5 tasks
abrokenjester added a commit that referenced this issue Jul 24, 2022
@abrokenjester
GH-4065 make QueryResult interface declare public methods directly
d0391cd
abrokenjester added a commit that referenced this issue Jul 24, 2022
@abrokenjester
GH-4065 define public api to avoid incorrect deprecation messages
1562951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abrokenjester abrokenjester

Labels
🐞 bug issue is a bug
Projects
None yet
Milestone
4.1.0
Development

Successfully merging a pull request may close this issue.

GH-4065 public api deprecation fixes eclipse-rdf4j/rdf4j
1 participant
@abrokenjester