Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release review #4091

Closed
4 tasks done
hmottestad opened this issue Jul 30, 2022 · 0 comments · Fixed by #4097
Closed
4 tasks done

Release review #4091

hmottestad opened this issue Jul 30, 2022 · 0 comments · Fixed by #4097
Assignees
@hmottestad
Labels
🔧 internal task a project workflow / setup task not directly impacting end users

Comments

@hmottestad
Copy link
Contributor

hmottestad commented Jul 30, 2022 •
edited
Loading

Todo from the review

  • CONTRIBUTING file
  • Missing copyright headers
  • Eclipse foundation terms of use
  • SPDX
@hmottestad hmottestad self-assigned this Jul 30, 2022
@hmottestad hmottestad added the 🔧 internal task a project workflow / setup task not directly impacting end users label Jul 30, 2022
This was referenced Jul 30, 2022
Closed
Merged
Closed
hmottestad added a commit that referenced this issue Jul 30, 2022
@hmottestad
GH-4091 changes based on release review
95d58c6
hmottestad added a commit that referenced this issue Jul 30, 2022
@hmottestad
GH-4091 update links
f1df442
hmottestad added a commit that referenced this issue Jul 31, 2022
@hmottestad
GH-4091 changes based on release review (#4095)
fc9e5aa 
* GH-4091 changes based on release review

* GH-4091 update links

* revert new line

* formatting
hmottestad added a commit that referenced this issue Jul 31, 2022
@hmottestad
GH-4091 add a newline in the copyright header
c6cb75f
@hmottestad hmottestad mentioned this issue Jul 31, 2022
Merged
5 tasks
hmottestad added a commit that referenced this issue Jul 31, 2022
@hmottestad
GH-4091 add a newline in the copyright header (#4097)
b849630 
* GH-4091 add a newline in the copyright header

* remove commented out files
hmottestad added a commit that referenced this issue Aug 18, 2022
@hmottestad
GH-4091 fix copyright headers
89e392e
hmottestad added a commit that referenced this issue Aug 18, 2022
@hmottestad
GH-4091 the maven formatter doesn't recognize the copyright header as…
086b1cf 
… a header comment when the package statement or an annotation comes too early in the file
hmottestad added a commit that referenced this issue Aug 18, 2022
@hmottestad
GH-4091 fix copyright headers (#4118)
15a7760 
* GH-4091 fix copyright headers

* GH-4091 the maven formatter doesn't recognize the copyright header as a header comment when the package statement or an annotation comes too early in the file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmottestad hmottestad

Labels
🔧 internal task a project workflow / setup task not directly impacting end users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-4091 add a newline in the copyright header eclipse-rdf4j/rdf4j
1 participant
@hmottestad