Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the hashcode used in the GroupIterator #4212

Closed
JervenBolleman opened this issue Sep 20, 2022 · 0 comments
Closed

Improve the hashcode used in the GroupIterator #4212

JervenBolleman opened this issue Sep 20, 2022 · 0 comments
Assignees
@JervenBolleman
Labels
🐞 bug issue is a bug M1 Fixed in milestone 1 ⏩ performance
Milestone
4.3.0

Comments

@JervenBolleman
Copy link
Contributor

Current Behavior

The current hash code of the GroupBy Key tends to saturate to all bits of the int set to 1 quickly due to use of ^= as the hash merge operation.

Expected Behavior

HashCode are supposed to be as well distributed as possible.
I suggest we change the hashcode to be a standard eclipse generated one.

Steps To Reproduce

No response

Version

4.2.0

Are you interested in contributing a solution yourself?

Yes

Anything else?

No response
@JervenBolleman JervenBolleman added the 🐞 bug issue is a bug label Sep 20, 2022
@JervenBolleman JervenBolleman self-assigned this Sep 20, 2022
JervenBolleman added a commit that referenced this issue Oct 17, 2022
@JervenBolleman
GH-4212 Hashcode for groupby elements less likely to trend to all val…
930267c 
…ues true

Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
@JervenBolleman JervenBolleman mentioned this issue Oct 17, 2022
Merged
5 tasks
@barthanssens barthanssens added this to the 4.3.0 milestone Oct 18, 2022
JervenBolleman added a commit that referenced this issue Nov 14, 2022
@JervenBolleman
GH-4212 Hashcode for groupby elements less likely to trend to all val…
c39c760 
…ues true

Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
@hmottestad hmottestad added the M1 Fixed in milestone 1 label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JervenBolleman JervenBolleman

Labels
🐞 bug issue is a bug M1 Fixed in milestone 1 ⏩ performance
Projects
None yet
Milestone
4.3.0
Development

No branches or pull requests
3 participants
@hmottestad @JervenBolleman @barthanssens