Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate RepositorySPARQLComplianceTestSuite to JUnit5 #4592

Closed
JervenBolleman opened this issue May 22, 2023 · 0 comments · Fixed by #4593
Closed

Migrate RepositorySPARQLComplianceTestSuite to JUnit5 #4592

JervenBolleman opened this issue May 22, 2023 · 0 comments · Fixed by #4593
Assignees
@JervenBolleman
Labels
📶 enhancement issue is a new feature or improvement M2 Fixed in milestone 2 M3 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks
Milestone
5.0.0

Comments

@JervenBolleman
Copy link
Contributor

Problem description

It currently is a JUnit4 Suite

Preferred solution

Junit5 testcases

Are you interested in contributing a solution yourself?

Yes

Alternatives you've considered

No response

Anything else?

No response
@JervenBolleman JervenBolleman added the 📶 enhancement issue is a new feature or improvement label May 22, 2023
@JervenBolleman JervenBolleman self-assigned this May 22, 2023
@JervenBolleman JervenBolleman added the 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks label May 22, 2023
JervenBolleman added a commit that referenced this issue May 22, 2023
@JervenBolleman
GH-4592 Replace a Junit4 Suite with v5 DynamicTest
070db50 
Also replaces a static so more tests should be runnable in parallel in
the future.

Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
@JervenBolleman JervenBolleman mentioned this issue May 22, 2023
Merged
5 tasks
@JervenBolleman JervenBolleman linked a pull request May 22, 2023 that will close this issue
GH-4592 Replace a Junit4 Suite with v5 DynamicTest #4593
Merged
5 tasks
@github-project-automation github-project-automation bot moved this to 🆕 Triage in RDF4J Planning May 22, 2023
JervenBolleman added a commit that referenced this issue May 22, 2023
@JervenBolleman
GH-4592 Replace more Junit4 Suite with v5 DynamicTest
ef38ad4 
Also delete some deprecated tests classes that are no longer compatible
with the junit5 way of doing things.
@JervenBolleman JervenBolleman mentioned this issue May 23, 2023
Draft
5 tasks
JervenBolleman added a commit that referenced this issue Oct 31, 2023
@JervenBolleman
GH-4592 Replace a Junit4 Suite with v5 DynamicTest
8888f77 
Also replaces a static so more tests should be runnable in parallel in
the future.

Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue Oct 31, 2023
@JervenBolleman
GH-4592 Replace more Junit4 Suite with v5 DynamicTest
8c33d62 
Also delete some deprecated tests classes that are no longer compatible
with the junit5 way of doing things.
JervenBolleman added a commit that referenced this issue Nov 3, 2023
@JervenBolleman
GH-4592 Make sure tests do not share state as they may concurrently.
e9d57aa
JervenBolleman added a commit that referenced this issue Nov 3, 2023
@JervenBolleman
GH-4592 Make sure tests do not share state as they run concurrently.
f289202
JervenBolleman added a commit that referenced this issue Nov 3, 2023
@JervenBolleman
GH-4592 Reduce code duplication and difference to the develop branch.
4fa9799
JervenBolleman added a commit that referenced this issue Nov 10, 2023
@JervenBolleman
GH-4592 Reenable geosparql junit testing.
3b0ec38 
Allow for non DAWG approved tests to run.
Adds a manifest-all.ttl file for geosparql like sparql 1.1. compliance.

Also remove some unused imports.
JervenBolleman added a commit that referenced this issue Nov 10, 2023
@JervenBolleman
Merge branch 'develop' into GH-4592-junit5-repository-sparql-compliance
4f3ba48
JervenBolleman added a commit that referenced this issue Nov 10, 2023
@JervenBolleman
GH-4592 Replace a Junit4 Suite with v5 DynamicTest
21fb00e 
Also replaces a static so more tests should be runnable in parallel in
the future.

Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue Nov 10, 2023
@JervenBolleman
GH-4592 Replace more Junit4 Suite with v5 DynamicTest
b7fc16b 
Also delete some deprecated tests classes that are no longer compatible
with the junit5 way of doing things.

Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue Nov 10, 2023
@JervenBolleman
GH-4592 Make sure tests do not share state as they run concurrently.
940e316 
Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue Nov 10, 2023
@JervenBolleman
GH-4592 Reduce code duplication and difference to the develop branch.
7beed16 
Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue Nov 10, 2023
@JervenBolleman
GH-4592 Reenable geosparql junit testing.
da3e01e 
Allow for non DAWG approved tests to run.
Adds a manifest-all.ttl file for geosparql like sparql 1.1. compliance.

Also remove some unused imports.
Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue Nov 10, 2023
@JervenBolleman
GH-4592 Fix missing @testfactory
04143fb
JervenBolleman added a commit that referenced this issue Nov 23, 2023
@JervenBolleman
GH-4592 Replace a Junit4 Suite with v5 DynamicTest
5813329 
Also replaces a static so more tests should be runnable in parallel in
the future.

Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue Nov 23, 2023
@JervenBolleman
GH-4592 Replace more Junit4 Suite with v5 DynamicTest
e6cff43 
Also delete some deprecated tests classes that are no longer compatible
with the junit5 way of doing things.

Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue Nov 23, 2023
@JervenBolleman
GH-4592 Make sure tests do not share state as they run concurrently.
723be75 
Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue Nov 23, 2023
@JervenBolleman
GH-4592 Reduce code duplication and difference to the develop branch.
166890e 
Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue Nov 23, 2023
@JervenBolleman
GH-4592 Reenable geosparql junit testing.
9580b85 
Allow for non DAWG approved tests to run.
Adds a manifest-all.ttl file for geosparql like sparql 1.1. compliance.

Also remove some unused imports.
Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue Nov 23, 2023
@JervenBolleman
GH-4592 Fix missing @testfactory
bb7ac22
hmottestad added a commit that referenced this issue Jan 12, 2024
@hmottestad
GH-4592 allows users to see variables that are used in compliance tests
4de4207
@hmottestad hmottestad mentioned this issue Jan 12, 2024
Merged
5 tasks
hmottestad added a commit that referenced this issue Jan 12, 2024
@hmottestad
GH-4592 allow users to see variables used in compliance tests (#4869)
39e789b
@hmottestad hmottestad added this to the 5.0.0 milestone Jan 12, 2024
@hmottestad hmottestad added M3 M2 Fixed in milestone 2 labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JervenBolleman JervenBolleman

Labels
📶 enhancement issue is a new feature or improvement M2 Fixed in milestone 2 M3 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

GH-4592 Replace a Junit4 Suite with v5 DynamicTest eclipse-rdf4j/rdf4j
2 participants
@hmottestad @JervenBolleman