GH-1995 push release branch and automate PR creation #1997
Conversation
- push release branch to avoid direct commits on master - use hub command to create PR for release branch to master - use hub command to create PR for updating develop branch
|
I will merge this immediately so I can use it for the 3.1.2 release. Only way to really debug, unfortunately, is to actually use it for a release. @hmottestad still interested in your review though. |
|
For testing i have previously forked the RDF4J repo. |
| @@ -153,7 +165,7 @@ git pull | |||
|
|
|||
| MVN_VERSION_DEVELOP=$(xmllint --xpath "//*[local-name()='project']/*[local-name()='version']/text()" pom.xml) | |||
|
|
|||
| git checkout master | |||
| git checkout ${BRANCH} | |||
|
|
|||
There was a problem hiding this comment.
Isn’t this the branch we are on already?
There was a problem hiding this comment.
Yes, good point
| echo "The release script requires several external command line tools:" | ||
| echo " - git" | ||
| echo " - mvn" | ||
| echo " - hub (https://hub.github.com/)" |
There was a problem hiding this comment.
Can we use the official command line client instead? https://cli.github.com/
There was a problem hiding this comment.
Or is the benefit of using hub that we don’t have to log in again?
There was a problem hiding this comment.
Btw. We need to test that hub (or whatever we end up with) works as an early step in the script. So it doesn’t crash half way through.
There was a problem hiding this comment.
I wasn't aware there was another client, I thought hub is the official client. Happy to consider alternatives if they're better.
There was a problem hiding this comment.
Or is the benefit of using hub that we don’t have to log in again?
No and actually that brings up a point: you need to set this tool up first before it works.
GitHub issue resolved: #1995