Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2048 remove code that has been commented out #2050

Merged
merged 1 commit into from
Mar 29, 2020
Merged

GH-2048 remove code that has been commented out #2050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions ...ion/src/main/java/org/eclipse/rdf4j/query/algebra/evaluation/impl/QueryJoinOptimizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

/**
* A query optimizer that re-orders nested Joins.
*
*
* @author Arjohn Kampman
* @author James Leigh
*/
Expand All @@ -48,7 +48,7 @@ public QueryJoinOptimizer(EvaluationStatistics statistics) {

/**
* Applies generally applicable optimizations: path expressions are sorted from more to less specific.
*
*
* @param tupleExpr
*/
@Override
Expand Down Expand Up @@ -231,17 +231,17 @@ protected List<TupleExpr> getSubSelects(List<TupleExpr> expressions) {
* maximized.
* <p>
* Example: reordering
*
*
* <pre>
* [f] [a b c] [e f] [a d] [b e]
* </pre>
*
*
* should result in:
*
*
* <pre>
* [a b c] [a d] [b e] [e f] [f]
* </pre>
*
*
* @param subselects the original ordering of expressions
* @return the optimized ordering of expressions
*/
Expand Down Expand Up @@ -421,13 +421,6 @@ protected double getTupleExprCardinality(TupleExpr tupleExpr, Map<TupleExpr, Dou
}
}

// Prefer patterns that bind more variables
// List<Var> distinctUnboundVars = getUnboundVars(new
// HashSet<Var>(vars));
// if (distinctUnboundVars.size() >= 2) {
// cardinality /= distinctUnboundVars.size();
// }

return cardinality;
}

Expand Down