GH-2078 property path negation and inversion

[hmottestad]

GitHub issue resolved: #2078

Briefly describe the changes proposed in this PR:

---

PR Author Checklist:

• my pull request is self-contained
• I've added tests for the changes I made
• every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change
• every commit has been signed off

Note: we merge all feature pull requests using squash and merge. See RDF4J git merge strategy for more details.

[abrokenjester]

I've pushed what I think is a decent fix for the immediate issue.

@hmottestad this is really a bug fix and should be merged to master, but unfortunately the feature branch is based off of develop. Could you rebase and target master? Alternatively, we can merge this and then cherry pick back onto master.

[abrokenjester]

ACtually just realized i didn't run all compliance tests - I think I may have overlooked a corner case.

[abrokenjester]

I'm fine with merging this as-is. A squash-merge + cherry-pick to get it onto master is fine with me. I'm on the fence whether we should log a separate issue to refactor the SPARQL parser a bit, make it less of a tangle.

[hmottestad]

Thank for fixing this @jeenbroekstra

I've added a couple more tests, and one of them looks a bit wonky. It's not so much incorrect I think as it is just a bit bloated.

This is the query:

PREFIX : <http://example.org/>
ASK { :IBM ^(:|!:) ?jane, ?jane2. }

And this is the plan:

Slice ( limit=1 )
   Join
      Union
         Join
            StatementPattern (resultSizeEstimate=UNKNOWN)
               Var (name=jane)
               Var (name=_const_7193c6e1_uri, value=http://example.org/, anonymous)
               Var (name=_const_1bf5dbd3_uri, value=http://example.org/IBM, anonymous)
            StatementPattern (resultSizeEstimate=UNKNOWN)
               Var (name=jane2)
               Var (name=_const_7193c6e1_uri, value=http://example.org/, anonymous)
               Var (name=_const_1bf5dbd3_uri, value=http://example.org/IBM, anonymous)
         Filter
            Compare (!=)
               Var (name=_anon_ee21cdb5_6a14_4539_a854_ed672dcc589d, anonymous)
               ValueConstant (value=http://example.org/)
            Join
               StatementPattern (resultSizeEstimate=UNKNOWN)
                  Var (name=jane2)
                  Var (name=_anon_ee21cdb5_6a14_4539_a854_ed672dcc589d, anonymous)
                  Var (name=_const_1bf5dbd3_uri, value=http://example.org/IBM, anonymous)
               StatementPattern (resultSizeEstimate=UNKNOWN)
                  Var (name=jane)
                  Var (name=_anon_ee21cdb5_6a14_4539_a854_ed672dcc589d, anonymous)
                  Var (name=_const_1bf5dbd3_uri, value=http://example.org/IBM, anonymous)
      Union
         Join
            StatementPattern (resultSizeEstimate=UNKNOWN)
               Var (name=jane)
               Var (name=_const_7193c6e1_uri, value=http://example.org/, anonymous)
               Var (name=_const_1bf5dbd3_uri, value=http://example.org/IBM, anonymous)
            StatementPattern (resultSizeEstimate=UNKNOWN)
               Var (name=jane2)
               Var (name=_const_7193c6e1_uri, value=http://example.org/, anonymous)
               Var (name=_const_1bf5dbd3_uri, value=http://example.org/IBM, anonymous)
         Filter
            Compare (!=)
               Var (name=_anon_ee21cdb5_6a14_4539_a854_ed672dcc589d, anonymous)
               ValueConstant (value=http://example.org/)
            Join
               StatementPattern (resultSizeEstimate=UNKNOWN)
                  Var (name=jane2)
                  Var (name=_anon_ee21cdb5_6a14_4539_a854_ed672dcc589d, anonymous)
                  Var (name=_const_1bf5dbd3_uri, value=http://example.org/IBM, anonymous)
               StatementPattern (resultSizeEstimate=UNKNOWN)
                  Var (name=jane)
                  Var (name=_anon_ee21cdb5_6a14_4539_a854_ed672dcc589d, anonymous)
                  Var (name=_const_1bf5dbd3_uri, value=http://example.org/IBM, anonymous)

Should be something like this:

Slice ( limit=1 )
   Join
      Union
         StatementPattern (resultSizeEstimate=UNKNOWN)
            Var (name=jane)
            Var (name=_const_7193c6e1_uri, value=http://example.org/, anonymous)
            Var (name=_const_1bf5dbd3_uri, value=http://example.org/IBM, anonymous)
         Filter
            Compare (!=)
               Var (name=_anon_8b0343a3_70a5_47db_adde_8128fbfa9f0d, anonymous)
               ValueConstant (value=http://example.org/)
            StatementPattern (resultSizeEstimate=UNKNOWN)
               Var (name=jane)
               Var (name=_anon_8b0343a3_70a5_47db_adde_8128fbfa9f0d, anonymous)
               Var (name=_const_1bf5dbd3_uri, value=http://example.org/IBM, anonymous)
      Union
         StatementPattern (resultSizeEstimate=UNKNOWN)
            Var (name=jane2)
            Var (name=_const_7193c6e1_uri, value=http://example.org/, anonymous)
            Var (name=_const_1bf5dbd3_uri, value=http://example.org/IBM, anonymous)
         Filter
            Compare (!=)
               Var (name=_anon_753de35b_1560_4eca_a727_9b48d975b9fb, anonymous)
               ValueConstant (value=http://example.org/)
            StatementPattern (resultSizeEstimate=UNKNOWN)
               Var (name=jane2)
               Var (name=_anon_753de35b_1560_4eca_a727_9b48d975b9fb, anonymous)
               Var (name=_const_1bf5dbd3_uri, value=http://example.org/IBM, anonymous)

[abrokenjester]

Yes, I did notice that too, and it is a bug of some sort (the produced algebra is not incorrect, just more complex than it needs to be - it essentially duplicate the entire tree for both object list arguments). It is not directly related to this particular bug though. I suggest you remove that test again and log a separate issue.

[abrokenjester]

Huh, look at that, new feature in github I think: you can convert a pull request back to draft (option appeared for me top-right, underneath the list of reviewers).