Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4119 LMDB store in Workbench #4120

Merged
merged 1 commit into from
Sep 1, 2022
Merged

GH-4119 LMDB store in Workbench #4120

merged 1 commit into from
Sep 1, 2022

Conversation

hmottestad
Copy link
Contributor

@hmottestad hmottestad commented Aug 18, 2022

GitHub issue resolved: #4119

Briefly describe the changes proposed in this PR:


PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@hmottestad
Copy link
Contributor Author

@kenwenzel you can try this out by checking out my branch and going to the docker directory and running ./build.sh followed by docker-compose up -d and then go to http://localhost:8080/rdf4j-workbench.

@hmottestad
Copy link
Contributor Author

@jeenbroekstra i want to merge the changes that allow the LMDB store to be created from the workbench, since I thought that this had already been included in RDF4J 4.1.0 so I put it in the release announcement.

The other changes, which are more performance related I'll retarget to 4.2.0 together with config options in the workbench for LMDB and SHACL/RDFS/etc.

@abrokenjester
Copy link
Contributor

@jeenbroekstra i want to merge the changes that allow the LMDB store to be created from the workbench, since I thought that this had already been included in RDF4J 4.1.0 so I put it in the release announcement.

Sounds good. I had a glance at the PR and it looks legit. Have you had a chance to run the changes in the workbench and check that it works?

The other changes, which are more performance related I'll retarget to 4.2.0 together with config options in the workbench for LMDB and SHACL/RDFS/etc.

👍

@hmottestad
Copy link
Contributor Author

Yeah. I use the docker script to run it up. Works well.

@hmottestad hmottestad force-pushed the GH-4119-lmdb-workbench branch 2 times, most recently from c5aa00d to 978ffd5 Compare August 30, 2022 13:38
@hmottestad hmottestad marked this pull request as ready for review September 1, 2022 11:51
@hmottestad hmottestad merged commit 320d36f into main Sep 1, 2022
@hmottestad hmottestad deleted the GH-4119-lmdb-workbench branch September 1, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create LMDB store from server REST API (or workbench UI)
2 participants