Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4146 Fixes for REST Isolation-level settings #4185

Merged
merged 1 commit into from
Sep 13, 2022
Merged

GH-4146 Fixes for REST Isolation-level settings #4185

merged 1 commit into from
Sep 13, 2022

Conversation

nguyenm100
Copy link
Contributor

@nguyenm100 nguyenm100 commented Sep 13, 2022

patch for: #4146

resubmitting with correct credentials to satisfy eca

@nguyenm100
Copy link
Contributor Author

@jeenbroekstra - please use this PR for the Isolation fixes. It has your feedback updates.. I accidentally checked in some of my changes using my work email on the last PR and it failed the eca.

@abrokenjester
Copy link
Contributor

@jeenbroekstra - please use this PR for the Isolation fixes. It has your feedback updates.. I accidentally checked in some of my changes using my work email on the last PR and it failed the eca.

Thanks for taking care of it! I've done that a few times myself. Btw you may know this already but you can set the e-mail address used for your commits on a specific repo by navigating to the repo root and doing git config user.email <email>. You can also set a global (on your current machine) default by doing git config --global user.email <email>.

@abrokenjester
Copy link
Contributor

@nguyenm100 as an aside, could you take another glance at our contribution guidelines, in particular the points about commit messages, PR descriptions and such? For one thing, we make a point of having the Github issue number at the start of every commit message and at the start of the PR title as well. This makes it easier for us to relate changes back to the issue even after things have been merged.

No worries if occasionally something slips through of course, but I'd prefer it not to become a habit :)

@abrokenjester abrokenjester changed the title Fixes for REST Isolation-level settings GH-4146 Fixes for REST Isolation-level settings Sep 13, 2022
Copy link
Contributor

@abrokenjester abrokenjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isolation Levels on REST api not working?
2 participants