Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4248 check for invalid triple context value #4282

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

abrokenjester
Copy link
Contributor

@abrokenjester abrokenjester commented Nov 12, 2022

GitHub issue resolved: #4248

Briefly describe the changes proposed in this PR:

  • added explicit check in SailSourceConnection to avoid adding Triple as a context value
  • added test coverage

PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@abrokenjester abrokenjester force-pushed the GH-4248/triple-as-context-bug branch 2 times, most recently from 5cb3978 to 618a172 Compare November 13, 2022 03:10
@abrokenjester abrokenjester changed the title GH-4248 check for invalid triple context value. added regression tests GH-4248 check for invalid triple context value Nov 13, 2022
@abrokenjester abrokenjester marked this pull request as ready for review November 13, 2022 03:15
@abrokenjester abrokenjester merged commit 660de6f into main Nov 18, 2022
@abrokenjester abrokenjester deleted the GH-4248/triple-as-context-bug branch November 18, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting a triple as a statement's context breaks repository.
1 participant