Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4489 User defined SPARQL queries in SHACL constraints and targets #4490

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

hmottestad
Copy link
Contributor

@hmottestad hmottestad commented Mar 16, 2023

GitHub issue resolved: #4489

Briefly describe the changes proposed in this PR:

  • Support for SPARQL based constraints (from the SHACL spec)
  • Support for SPARQL based targets (from the SHACL Advanced Features Working Group Note)

PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@hmottestad hmottestad force-pushed the GH-4489_SPARQL_Constraints_Targets branch from 1d2142d to e15f2fa Compare March 16, 2023 06:54
@hmottestad hmottestad force-pushed the GH-4489_SPARQL_Constraints_Targets branch from 9c97261 to 5af6682 Compare March 16, 2023 12:31
@hmottestad
Copy link
Contributor Author

I was considering if we should have a config option to enable the SHACL Advanced Features, but since it's in the same namespace I don't really want to complicate things.

@hmottestad hmottestad marked this pull request as ready for review March 16, 2023 13:52
Copy link
Contributor

@abrokenjester abrokenjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't fully reviewed (it's a lot) but overall LGTM.

Slightly worried that we are duplicating existing SPARQL-related functionality inside the shaclsail module but I trust you won't let that get out of hand.

@hmottestad hmottestad merged commit b5ac3fb into develop Mar 20, 2023
@hmottestad hmottestad deleted the GH-4489_SPARQL_Constraints_Targets branch March 20, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants