Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Include the invalid IRI in the IllegalArgumentException when validating IRIs in the ValidatingValueFactory #4919

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix: Include the invalid IRI in the IllegalArgumentException when validating IRIs in the ValidatingValueFactory #4919

merged 1 commit into from
Mar 6, 2024

Conversation

vorburger
Copy link
Contributor

@vorburger vorburger commented Feb 24, 2024 •
edited
Loading

PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

vorburger added a commit to vorburger/enola that referenced this pull request Feb 26, 2024
@vorburger
fix (core): Provide more context on IRI creation errors in ThingRdfCo…
fb7577c 
…nverter

Workaround until eclipse-rdf4j/rdf4j#4919 get merged,
a new RDF4j version is released and we bumped to that; until then, this is useful.
@vorburger vorburger mentioned this pull request Feb 26, 2024
Merged
vorburger added a commit to enola-dev/enola that referenced this pull request Feb 26, 2024
@vorburger
fix (core): Provide more context on IRI creation errors in ThingRdfCo…
a56a460 
…nverter

Workaround until eclipse-rdf4j/rdf4j#4919 get merged,
a new RDF4j version is released and we bumped to that; until then, this is useful.
@hmottestad hmottestad changed the title fix: Include !isAbsolute IRI in IllegalArgumentException of ValidatingValueFactory fix: Include the invalid IRI in the IllegalArgumentException when validating IRIs in the ValidatingValueFactory Mar 6, 2024
@hmottestad hmottestad merged commit cb40e67 into eclipse-rdf4j:main Mar 6, 2024
9 checks passed
vorburger added a commit to vorburger/enola that referenced this pull request Sep 22, 2024
@vorburger
clean(core): Remove createIRI() error handling workaround
620b837 
Now that we're on an RDF4j release which includes (my)
eclipse-rdf4j/rdf4j#4919 fix.
vorburger added a commit to enola-dev/enola that referenced this pull request Sep 23, 2024
@vorburger
clean(core): Remove createIRI() error handling workaround
4af7498 
Now that we're on an RDF4j release which includes (my)
eclipse-rdf4j/rdf4j#4919 fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vorburger @hmottestad