Initial Eclipse S-CORE Development Container#1
Conversation
dc2ff93 to
fbd77ad
Compare
| @@ -0,0 +1 @@ | |||
| * @opajonk @lurtz | |||
There was a problem hiding this comment.
This likely needs an update. Please suggest how this should look like.
There was a problem hiding this comment.
CODEOWNERS are the people that are required to approve a PR before it can be merged.
In this repository, it seems you two are the main protagonists, so for me this seems fine.
067a0dd to
a6af59b
Compare
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GHCR_TOKEN }} |
There was a problem hiding this comment.
This will need an update. We need a secret which is allowed to publish to the image registry.
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GHCR_TOKEN }} |
There was a problem hiding this comment.
This will need an update. We need a secret which is allowed to publish to the image registry.
There was a problem hiding this comment.
When I test the .devcontainer at communication I get this error:
[2025-07-04T21:34:13.296Z] {"errors":[{"code":"DENIED","message":"requested access to the resource is denied"}]}
.
[2025-07-04T21:34:13.479Z] [httpOci] 403: Failed to fetch bearer token for 'ghcr.io': {"errors":[{"code":"DENIED","message":"requested access to the resource is denied"}]}
[2025-07-04T21:34:13.479Z] [httpOci] ERR: Failed to fetch Bearer token from registry.
[2025-07-04T21:34:13.479Z] Request 'https://ghcr.io/v2/eclipse-score/devcontainer/manifests/latest' failed
[2025-07-04T21:34:13.858Z] [httpOci] 403: Credentials for 'ghcr.io' may be expired. Attempting request anonymously.
[2025-07-04T21:34:13.858Z] {"errors":[{"code":"DENIED","message":"requested access to the resource is denied"}]}
.
[2025-07-04T21:34:14.045Z] [httpOci] 403: Failed to fetch bearer token for 'ghcr.io': {"errors":[{"code":"DENIED","message":"requested access to the resource is denied"}]}
[2025-07-04T21:34:14.045Z] [httpOci] ERR: Failed to fetch Bearer token from registry.
[2025-07-04T21:34:14.045Z] Request 'https://ghcr.io/v2/eclipse-score/devcontainer/manifests/latest' failed
[2025-07-04T21:34:14.045Z] Error fetching image details: No manifest found for ghcr.io/eclipse-score/devcontainer:latest.
[2025-07-04T21:34:14.046Z] Start: Run: docker pull ghcr.io/eclipse-score/devcontainer:latest
[2025-07-04T21:34:14.485Z] Error response from daemon: Head "https://ghcr.io/v2/eclipse-score/devcontainer/manifests/latest": denied
[2025-07-04T21:34:14.488Z] Stop (442 ms): Run: docker pull ghcr.io/eclipse-score/devcontainer:latest
Is this expected?
This is the used config
{
"name": "eclipse-s-core",
"image": "ghcr.io/eclipse-score/devcontainer:latest",
"initializeCommand": "mkdir -p ${localEnv:HOME}/.cache/bazel"
}
There was a problem hiding this comment.
Yes that will work only after the merge. The CI did not run in S-CORE context yet.
ca03906 to
bde4da6
Compare
|
Force pushed last iteration. Things are complete finally. I missed one thing, that still had to be fixed. |
| - repo: https://github.com/pre-commit/pre-commit-hooks | ||
| rev: cef0300fd0fc4d2a87a85fa2093c6b283ea36f4b # v5.0.0 | ||
| hooks: | ||
| - id: check-yaml | ||
| - id: end-of-file-fixer | ||
| exclude: "devcontainer-lock.json" | ||
| - id: trailing-whitespace | ||
| - id: check-shebang-scripts-are-executable | ||
| - id: check-executables-have-shebangs |
There was a problem hiding this comment.
Me personally would never force pre-commit anything.
But if this helps your workflow & you want this in your repository, seems fine by me.
There was a problem hiding this comment.
I would recommend this, yes. We have made very good experience with "strict automated checks, but open to changes". What I mean is: don't "overdocument" and "overchecklist" - rather have an automation do it. This is cheap and can handle really a lot of issues. But: be open if people have doubts about settings. It should be always possible to discuss and give arguments why things are set like they are.
| "bazelbuild.vscode-bazel", | ||
| "dbaeumer.vscode-eslint", | ||
| "EditorConfig.EditorConfig", | ||
| "llvm-vs-code-extensions.vscode-clangd", |
There was a problem hiding this comment.
We might need the 'codelens' extension here too, as Esbonio does not seem great with publishing / showing the errors.
But this could be added if needed (based on user feedback)
There was a problem hiding this comment.
Absolutely. I consider this container the 1.0.0 - "works on the known use-cases" (which was to me: "run bazel build" or whatever bazel commands were documented; e.g. for FEO I also tried running the example). Adding / changing later is really "just a pull-request away" ;-)
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
For me this looks fine, as far as I understand it.
Seems to be a rather thoroughly integrated feature, thanks for the hard work on this.
I think once there is users more requirements will come to light & adaptations can be made accordingly.
This PR introduces a pre-built devcontainer with all features required by eclipse-score/score#1256
In detail, that means:
baselibs,communication,inc_feo.The devcontainer itself is maintained and built using a (very simple) devcontainer. All build scripts can be executed locally as well as in CI. See README for details on that.
Closes eclipse-score/score#1256