fix: update type checks for component and module in UML drawing functions#338
Merged
MaximilianSoerenPollak merged 1 commit intoeclipse-score:mainfrom Jan 13, 2026
Merged
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //src:license-checkStatus: Click to expand output |
There was a problem hiding this comment.
Pull request overview
This PR updates type checks in UML drawing functions to align with metamodel changes, replacing old verbose type names with shorter, simplified versions.
Key changes:
- Type
comp_arc_starenamed tocomp - Type
mod_view_starenamed tomod
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/extensions/score_draw_uml_funcs/helpers.py | Updated component type check in safety formatting logic from comp_arc_sta to comp |
| src/extensions/score_draw_uml_funcs/init.py | Updated type validation in module drawing function to use new type names comp and mod instead of comp_arc_sta and mod_view_sta |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The created documentation from the pull request is available at: docu-html |
2 tasks
FScholPer
approved these changes
Jan 12, 2026
MaximilianSoerenPollak
approved these changes
Jan 13, 2026
RolandJentschETAS
pushed a commit
to etas-contrib/score_docs-as-code
that referenced
this pull request
Jan 13, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metamodel was updated, but not the draw_umml functions