infra: fix dash internal checks#34
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
There was a problem hiding this comment.
Pull request overview
This PR fixes the internal DASH license checker configuration by correcting the Cargo.lock file path and filtering out local dependencies to ensure only third-party packages are checked.
Changes:
- Removed the copyright_checker rule
- Added a genrule to filter local dependencies from Cargo.lock
- Updated dash_license_checker to use the filtered Cargo.lock file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| template = "@score_tooling//cr_checker/resources:templates", | ||
| visibility = ["//visibility:public"], | ||
| # Needed for Dash tool to check python dependency licenses. | ||
| # This is a workaround to filter out local packages from the Cargo.lock file. |
There was a problem hiding this comment.
Corrected spelling of 'depenendencies' to 'dependencies' in comment.
|
The created documentation from the pull request is available at: docu-html |
78700e1 to
e6858e7
Compare
|
@FScholPer, @PiotrKorkus, is this not merged because of the failing CI? |
|
We fixed the CI, would be great if you can rebase this PR @PiotrKorkus |
- Use correct Cargo.lock file - Filter out local depenendencies as only 3rd party should be checked
e6858e7 to
b46752d
Compare
@johannes-esr does still not work? |
Bugfix
Important
Use this template only for bugfixes that do not influence topics covered by contribution requests or improvements.
Caution
Make sure to submit your pull-request as Draft until you are ready to have it reviewed by the Committers.
Description
[A short description of the bug being fixed by the contribution.]
Related ticket
Important
Please replace
[ISSUE-NUMBER]with the issue-number that tracks this bug fix. If there is no suchticket yet, create one via this issue template.
closes #16