Skip to content

Comments

infra: fix dash internal checks#34

Merged
masc2023 merged 2 commits intoeclipse-score:mainfrom
qorix-group:piotrkorkus_fix_dash_check
Feb 11, 2026
Merged

infra: fix dash internal checks#34
masc2023 merged 2 commits intoeclipse-score:mainfrom
qorix-group:piotrkorkus_fix_dash_check

Conversation

@PiotrKorkus
Copy link
Contributor

  • Use correct Cargo.lock file
  • Filter out local depenendencies as only 3rd party should be checked

Bugfix

Important

Use this template only for bugfixes that do not influence topics covered by contribution requests or improvements.

Caution

Make sure to submit your pull-request as Draft until you are ready to have it reviewed by the Committers.

Description

[A short description of the bug being fixed by the contribution.]

Related ticket

Important

Please replace [ISSUE-NUMBER] with the issue-number that tracks this bug fix. If there is no such
ticket yet, create one via this issue template.

closes #16

@github-actions
Copy link

github-actions bot commented Jan 27, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 0cff0f36-00b7-4cd2-98ce-f90f9a31f309
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.5.3, but got aspect_rules_lint@2.0.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.8.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (14 packages loaded, 9 targets configured)

Analyzing: target //:license-check (73 packages loaded, 9 targets configured)

Analyzing: target //:license-check (86 packages loaded, 9 targets configured)

Analyzing: target //:license-check (110 packages loaded, 148 targets configured)

Analyzing: target //:license-check (154 packages loaded, 2283 targets configured)

Analyzing: target //:license-check (155 packages loaded, 3053 targets configured)

Analyzing: target //:license-check (159 packages loaded, 3068 targets configured)

Analyzing: target //:license-check (159 packages loaded, 3068 targets configured)

Analyzing: target //:license-check (159 packages loaded, 3068 targets configured)

Analyzing: target //:license-check (167 packages loaded, 9234 targets configured)

Analyzing: target //:license-check (186 packages loaded, 9301 targets configured)
[12 / 17] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 250 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
Analyzing: target //:license-check (192 packages loaded, 9316 targets configured)
[14 / 17] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 1s disk-cache, processwrapper-sandbox
Analyzing: target //:license-check (192 packages loaded, 9316 targets configured)
[15 / 17] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
Analyzing: target //:license-check (192 packages loaded, 9316 targets configured)
[16 / 17] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
Analyzing: target //:license-check (192 packages loaded, 9316 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (193 packages loaded, 13650 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (193 packages loaded, 13650 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (193 packages loaded, 13650 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (193 packages loaded, 13650 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (193 packages loaded, 13650 targets configured)
[17 / 17] no actions running
DEBUG: Rule 'rules_rust++rust+rust_linux_x86_64__x86_64-unknown-linux-gnu__stable_tools' indicated that a canonical reproducible form can be obtained by modifying arguments sha256s = {"rustc-1.93.0-x86_64-unknown-linux-gnu.tar.xz": "00c6e6740ea6a795e33568cd7514855d58408a1180cd820284a7bbf7c46af715", "clippy-1.93.0-x86_64-unknown-linux-gnu.tar.xz": "793108977514b15c0f45ade28ae35c58b05370cb0f22e89bd98fdfa61eabf55d", "cargo-1.93.0-x86_64-unknown-linux-gnu.tar.xz": "c23de3ae709ff33eed5e4ae59d1f9bcd75fa4dbaa9fb92f7b06bfb534b8db880", "llvm-tools-1.93.0-x86_64-unknown-linux-gnu.tar.xz": "86159dfa25c40cc7187ed9740f571b1c1ba3cc2d59a2ab1d12aa37198c96ba40", "rust-std-1.93.0-x86_64-unknown-linux-gnu.tar.xz": "a849a418d0f27e69573e41763c395e924a0b98c16fcdc55599c1c79c27c1c777"}
DEBUG: Repository rules_rust++rust+rust_linux_x86_64__x86_64-unknown-linux-gnu__stable_tools instantiated at:
  <builtin>: in <toplevel>
Repository rule rust_toolchain_tools_repository defined at:
  /home/runner/.bazel/external/rules_rust+/rust/repositories.bzl:567:50: in <toplevel>
Analyzing: target //:license-check (193 packages loaded, 13650 targets configured)
[17 / 17] no actions running
INFO: Analyzed target //:license-check (196 packages loaded, 13756 targets configured).
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 45.893s, Critical Path: 4.42s
INFO: 17 processes: 12 internal, 4 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 17 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the internal DASH license checker configuration by correcting the Cargo.lock file path and filtering out local dependencies to ensure only third-party packages are checked.

Changes:

  • Removed the copyright_checker rule
  • Added a genrule to filter local dependencies from Cargo.lock
  • Updated dash_license_checker to use the filtered Cargo.lock file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

template = "@score_tooling//cr_checker/resources:templates",
visibility = ["//visibility:public"],
# Needed for Dash tool to check python dependency licenses.
# This is a workaround to filter out local packages from the Cargo.lock file.
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'depenendencies' to 'dependencies' in comment.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

@PiotrKorkus PiotrKorkus force-pushed the piotrkorkus_fix_dash_check branch from 78700e1 to e6858e7 Compare January 27, 2026 18:19
@johannes-esr
Copy link
Contributor

@FScholPer, @PiotrKorkus, is this not merged because of the failing CI?

@johannes-esr
Copy link
Contributor

We fixed the CI, would be great if you can rebase this PR @PiotrKorkus

- Use correct Cargo.lock file
- Filter out local depenendencies as only 3rd party should be checked
@masc2023 masc2023 force-pushed the piotrkorkus_fix_dash_check branch from e6858e7 to b46752d Compare February 11, 2026 06:12
@masc2023
Copy link
Contributor

We fixed the CI, would be great if you can rebase this PR @PiotrKorkus

@johannes-esr does still not work?

@masc2023 masc2023 closed this Feb 11, 2026
@masc2023 masc2023 reopened this Feb 11, 2026
@masc2023 masc2023 merged commit e62bc82 into eclipse-score:main Feb 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some dependencies need to be vetted

4 participants