-
Notifications
You must be signed in to change notification settings - Fork 9
QNX Toolchain setup for eclipse-score-logging #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add qnx_x86_64 and qnx_arm64 build configurations in .bazelrc - Register QNX QCC toolchains for x86_64 and aarch64 in MODULE.bazel - Make qnx_creds.py executable for credential helper functionality Issue: SWP-235282
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
rmaddikery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is scripts/internal/qnx_creds.py an empty file?
| common:qnx_x86_64 --sandbox_writable_path=/var/tmp | ||
|
|
||
| common:qnx_arm64 --host_platform=@score_bazel_platforms//:x86_64-linux | ||
| common:qnx_arm64 --platforms=@score_bazel_platforms//:arm64-qnx8_0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consolidate this section with line 39-43!
Otherwise this is just repetitive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
pawelrutkaq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add qnx builds jobs from reusable workflows in score.
MODULE.bazel
Outdated
| use_repo(toolchains_qnx, "toolchains_qnx_qcc") | ||
| use_repo(toolchains_qnx, "toolchains_qnx_ifs") | ||
|
|
||
| register_toolchains("@toolchains_qnx_qcc//:qcc_x86_64") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall never be registered
just change the permission of qnx_cred file. Yes, it’s needed: qnx_creds.py must be executable so Bazel can run it as --credential_helper during the QNX SDP fetch from qnx.com otherwise downloads fail |
- Add common:qnx base config to eliminate duplication. - Set qnx_creds.py as executable for credential helper Issue: SWP-235282
@Rahul-Sutariya |
We shall sue reusable workflows. https://github.com/eclipse-score/cicd-workflows |
|
Btw this has to go along with new rust toolchain for toolchain_rust .0.3.0 if you want to add x86_64 QNX |
Issue: SWP-235282
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #