Skip to content

score_basilibs: Update to official release 0.1.2#159

Merged
vinodreddy-g merged 3 commits intoeclipse-score:mainfrom
umaucher:um_baselibs_update
Nov 3, 2025
Merged

score_basilibs: Update to official release 0.1.2#159
vinodreddy-g merged 3 commits intoeclipse-score:mainfrom
umaucher:um_baselibs_update

Conversation

@umaucher
Copy link
Contributor

@umaucher umaucher commented Oct 30, 2025

  • Rename and updated score-baselibs 0.0 -> score_baselibs 0.1.2
  • Prepare handling for injected implicit score-baselibs dependency
  • Suppress compiler warnings (treated as errors) inherited
  • Rename all dependencies

Because of problems with the caching and the size of llvm we also decided in the scope of this PR to switch the toolchain:

  • Instead of using llvm from global bazel registry switch to score_toolchains_gcc.
  • Did needed changes to get compilation running.

This then required an update for the code coverage handling:
workflows/check: Update coverage workflow

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 5db9accf-bf41-4aa8-9625-1fd41eaf6bf5
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-oEubHgeZDdT0svMmBKJx7c3/2TdSI/vfwRUyDn+TPGA="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_rust', the root module requires module version rules_rust@0.56.0, but got rules_rust@0.61.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.1.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'platforms', the root module requires module version platforms@0.0.11, but got platforms@1.0.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)

Analyzing: target //:license-check (80 packages loaded, 9 targets configured)

Analyzing: target //:license-check (102 packages loaded, 150 targets configured)

Analyzing: target //:license-check (140 packages loaded, 3505 targets configured)

Analyzing: target //:license-check (143 packages loaded, 6570 targets configured)

INFO: Analyzed target //:license-check (146 packages loaded, 8586 targets configured).
[11 / 14] [Prepa] Executing genrule //:filtered_cargo_lock
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 65 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 21.542s, Critical Path: 0.51s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

- Rename and updated score-baselibs 0.0 -> score_baselibs 0.1.2
- Handling for injected implicit score-baselibs dependency
- Suppress compiler warnings (treated as errors) inherited
- Rename all dependencies
@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

Instead of using llvm from global bazel registry switch to
score_toolchains_gcc. Did needed changes to get compilation running.
Adapt the workflow to work with the new toolchain. Currently the coverage
report is created manually since the bazel coverage workflow is broken (see
eclipse-score/toolchains_gcc#21).
@umaucher umaucher marked this pull request as ready for review October 31, 2025 11:56
@umaucher
Copy link
Contributor Author

"coverage drop" will be investigated in #160

Copy link
Contributor

@arkjedrz arkjedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor TODO issue.

build --@score_baselibs//score/json:base_library=nlohmann
build --@score_baselibs//score/mw/log/flags:KRemote_Logging=False

# ToDo: needed for "wrong" implicit dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not clear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is related to a wrong dependency handling in other modules / modules we depend on (but I don't know which one tbh) so we still inherit dependencies to the "old" version of baselibs containing the - instead of _ in the name ... this is why we need to define for both the according flags for building

@vinodreddy-g vinodreddy-g merged commit e6842ad into eclipse-score:main Nov 3, 2025
13 checks passed
atarekra pushed a commit to Valeo-S-CORE-Organization/persistency that referenced this pull request Nov 9, 2025
* score_basilibs: Update to official release 0.1.2

- Rename and updated score-baselibs 0.0 -> score_baselibs 0.1.2
- Handling for injected implicit score-baselibs dependency
- Suppress compiler warnings (treated as errors) inherited
- Rename all dependencies

* toolchain: Switch from llvm to score gcc

Instead of using llvm from global bazel registry switch to
score_toolchains_gcc. Did needed changes to get compilation running.

* workflows/check: Update coverage workflow

Adapt the workflow to work with the new toolchain. Currently the coverage
report is created manually since the bazel coverage workflow is broken (see
eclipse-score/toolchains_gcc#21).
@umaucher umaucher deleted the um_baselibs_update branch November 12, 2025 14:38
Saumya-R pushed a commit to qorix-group/persistency that referenced this pull request Nov 19, 2025
* score_basilibs: Update to official release 0.1.2

- Rename and updated score-baselibs 0.0 -> score_baselibs 0.1.2
- Handling for injected implicit score-baselibs dependency
- Suppress compiler warnings (treated as errors) inherited
- Rename all dependencies

* toolchain: Switch from llvm to score gcc

Instead of using llvm from global bazel registry switch to
score_toolchains_gcc. Did needed changes to get compilation running.

* workflows/check: Update coverage workflow

Adapt the workflow to work with the new toolchain. Currently the coverage
report is created manually since the bazel coverage workflow is broken (see
eclipse-score/toolchains_gcc#21).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants