-
Notifications
You must be signed in to change notification settings - Fork 74
lib/bitmanipulation: Define AoU #2339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/bitmanipulation: Define AoU #2339
Conversation
|
|
|
The created documentation from the pull request is available at: docu-html |
aschemmel-tech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline comments
| :safety: ASIL_B | ||
| :status: valid | ||
|
|
||
| The user shall ensure that bit positions and bit ranges passed to bit manipulation functions are within valid bounds for the integral type being operated on. Bit positions must not exceed the type's bit width. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can this be read together with comp_req__bitmanipulation__bounds_safety: "if you give the bitmanipulation functions some wrong range then you will have to cope with an error return" or "if you give the bitmanipulation functions some wrong range then you may get back some wrong value" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
docs/modules/baselibs/bitmanipulation/docs/requirements/index.rst
Outdated
Show resolved
Hide resolved
d85f386 to
fca4bfb
Compare
aschemmel-tech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one topic fixed
| :status: valid | ||
|
|
||
| The user shall ensure that bit positions and bit ranges passed to bit manipulation functions are within valid bounds for the integral type being operated on. Bit positions must not exceed the type's bit width. | ||
| The bit manipulation API shall validate bit positions and ranges are within the integral type's bit width and prevent data corruption through bounds checking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but after this change it is not a Assumption of Use any more, but a requirement to be fulfilled by bit manipulation. More or less the same as comp_req__bitmanipulation__bounds_safety.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
aschemmel-tech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Defined AoU for library bitmanipulation