Skip to content

Conversation

@rahulthakre29
Copy link
Contributor

Defined AoU for library bitmanipulation

@rahulthakre29 rahulthakre29 requested a review from a team as a code owner December 15, 2025 12:51
@github-actions
Copy link

⚠️ Docs-as-Code version mismatch detected
Please check the CI build logs for details and align the documentation version with the Bazel dependency.

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

Copy link
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comments

:safety: ASIL_B
:status: valid

The user shall ensure that bit positions and bit ranges passed to bit manipulation functions are within valid bounds for the integral type being operated on. Bit positions must not exceed the type's bit width.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can this be read together with comp_req__bitmanipulation__bounds_safety: "if you give the bitmanipulation functions some wrong range then you will have to cope with an error return" or "if you give the bitmanipulation functions some wrong range then you may get back some wrong value" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

Copy link
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one topic fixed

:status: valid

The user shall ensure that bit positions and bit ranges passed to bit manipulation functions are within valid bounds for the integral type being operated on. Bit positions must not exceed the type's bit width.
The bit manipulation API shall validate bit positions and ranges are within the integral type's bit width and prevent data corruption through bounds checking.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but after this change it is not a Assumption of Use any more, but a requirement to be fulfilled by bit manipulation. More or less the same as comp_req__bitmanipulation__bounds_safety.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

Copy link
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@aschemmel-tech aschemmel-tech merged commit c524b24 into eclipse-score:main Dec 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants