issue_2501_created_missing_drafts#2600
issue_2501_created_missing_drafts#2600attifunel wants to merge 17 commits intoeclipse-score:mainfrom
Conversation
|
|
|
|
||
| **Checklist** | ||
|
|
||
| Please note that it is mandatory to fill in the "passed" column with "yes" or "no" for each checklist item and additional to add in the remarks why it is passed or not passed. In case of "no" an issue link to the issue tracking system has to be added in the last column. See also :ref:`review_concept` for further information about reviews in general and inspection in particular. |
There was a problem hiding this comment.
/home/runner/work/score/score/docs/safety/fdr_reports_safety_analyses_DFA.rst:38: WARNING: undefined label: 'review_concept' [ref.ref]
/home/runner/work/score/score/docs/safety/fdr_reports_safety_analyses_DFA.rst:58: WARNING: undefined label: 'doc__platform_dfa' [ref.ref]
/home/runner/work/score/score/docs/safety/fdr_reports_safety_package.rst:41: WARNING: undefined label: 'doc_concept__wp_inspections' [ref.ref]
/home/runner/work/score/score/docs/safety/fdr_reports_safety_platform_safety_plan.rst:40: WARNING: undefined label: 'doc_concept__wp_inspections' [ref.ref]
Only Sphinx-Needs links work across repos but not labels.
| - | ||
| * - REQ_01_02 | ||
| - Are the templates for DFA and/or FMEA used? | ||
| - See :ref:`doc__platform_dfa` |
There was a problem hiding this comment.
| - See :ref:`doc__platform_dfa` | |
| - See :need:`doc__platform_dfa` |
This should work.
|
The created documentation from the pull request is available at: docu-html |
masc2023
left a comment
There was a problem hiding this comment.
All documents seems to be templates, Templates should be in process_description, Template Folder not in SCORE repo
| **2. DFA Report** | ||
| - List of the performed component DFA, pass/fail with open mitigations | ||
|
|
||
| **3. Safety Analysis Report** |
There was a problem hiding this comment.
FMEA Report, as Safety Analysis in our context is superset including DFA and FMEA
There was a problem hiding this comment.
It is already split in DFA and next subchapter Safety Analysis (i.e. FMEAs). I'd keep this structure because they're actually two analyses of very different type
There was a problem hiding this comment.
Compare here, should follow up definition, safety analysis is used as superset including DFA, therefore I woul propose, mention DFA and FMEA or only the superset term
https://eclipse-score.github.io/process_description/main/process_areas/safety_analysis/safety_analysis_concept.html
There was a problem hiding this comment.
Looking at here Platform FMEA is not planned https://eclipse-score.github.io/process_description//main/process_areas/safety_analysis/safety_analysis_workproducts.html#wp__platform_dfa
There was a problem hiding this comment.
the verification report used a template that is not compliant to https://eclipse-score.github.io/process_description//main/process_areas/verification/verification_workproducts.html#wp__verification_platform_ver_report. I will rewrite it accordingly, thanks for the notification
docs/platform_management_plan/verification_report/platform_ver_report.rst
Outdated
Show resolved
Hide resolved
| :status: draft | ||
| :safety: ASIL_B | ||
| :security: NO | ||
| :realizes: wp__verification_module_ver_report |
There was a problem hiding this comment.
it it the platform verification report, so is these really realizing module verification report? I would assume each module has its own verification report and these is only the platform report
There was a problem hiding this comment.
I agree, I will check
| :safety: ASIL_B | ||
| :security: NO | ||
| :realizes: wp__verification_module_ver_report | ||
| :tags: template |
There was a problem hiding this comment.
If this is a template, why is it in SCORE, Templates should be part of process_description Template Folder?
There was a problem hiding this comment.
Sorry I will fix it
They are not templates, but drafts. The explanatory content from the template is kept to help filling the content accordingly. |
docs/platform_management_plan/verification_report/platform_ver_report.rst
Outdated
Show resolved
Hide resolved
| **2. DFA Report** | ||
| - List of the performed component DFA, pass/fail with open mitigations | ||
|
|
||
| **3. Safety Analysis Report** |
There was a problem hiding this comment.
Compare here, should follow up definition, safety analysis is used as superset including DFA, therefore I woul propose, mention DFA and FMEA or only the superset term
https://eclipse-score.github.io/process_description/main/process_areas/safety_analysis/safety_analysis_concept.html
| :safety: ASIL_B | ||
| :security: NO | ||
| :realizes: wp__verification_module_ver_report | ||
| :tags: template |
There was a problem hiding this comment.
IF it not template, then remove the tag template her and everywhere
| # ******************************************************************************* | ||
|
|
||
|
|
||
| Safety Analysis Checklist |
There was a problem hiding this comment.
Why is this not called like safety package: Safety Plan Formal Review Report -> Safety Analysis Formal Review Report, realizing anyway this work product?
| Safety Package Formal Review Report | ||
| =================================== | ||
|
|
||
| .. note:: Document header |
| Safety Plan Formal Review Report | ||
| ================================ | ||
|
|
||
| .. note:: Document header |
| Safety Manual | ||
| ============= | ||
|
|
||
| .. note:: Document header |
| Assumed Platform Safety Requirements | ||
| ------------------------------------ | ||
| | For the S-CORE Platformhe following safety related stakeholder requirements are assumed to define the top level functionality (purpose) of the S-CORE Platform. I.e. from these all the feature and component requirements implemented are derived. | ||
| | <List here all the stakeholder requirements, with safety not equal to QM, the module's components requirements are derived from.> |
There was a problem hiding this comment.
May easier to read, if you put this kind of actions List here.. in Bold or Note or Attention, that the user can replace this later or remove it, while this is not any more a template
| Assumptions on the Environment | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| | Generally the assumption of the project platform SEooC is that it is integrated in a safe system, i.e. the POSIX OS it runs on is qualified and also the HW related failures are taken into account by the system integrator, if not otherwise stated in the module's safety concept. | ||
| | <List here all the OS calls the project platform expects to be safe.> |
There was a problem hiding this comment.
same here, list is already there
| requirements/index | ||
| modules/index | ||
| contribute/index | ||
| safety/index |
There was a problem hiding this comment.
may move safety behind PMP
| Verification Report | ||
| =================== | ||
|
|
||
| .. note:: Document header |
| (can be several levels), passed/failed and completeness verdict, including normal | ||
| operation and failure reactions | ||
| - The list of requirements may also contain other verification methods like "Analysis" | ||
| - Formal evidence about the performed DFA |
There was a problem hiding this comment.
Platform DFA, other DFAs are part of Safety Analsis
| operation and failure reactions | ||
| - The list of requirements may also contain other verification methods like "Analysis" | ||
| - Formal evidence about the performed DFA | ||
| - Formal evidence about the performed Safety Analyses (if planned) |
There was a problem hiding this comment.
It's not too clear to me if we plan or not a Platform FMEA. They are not in the Safety Plan
|
The proper way of linking a PR to an issue is to put the number in the Commit message (but not in the headlines): |
aschemmel-tech
left a comment
There was a problem hiding this comment.
See inline comments
There was a problem hiding this comment.
Why was the template not used?
There was a problem hiding this comment.
I would not see this as part of the PMP as it is not about planning. Part of Release? Safety?
There was a problem hiding this comment.
I can move it to safety
docs/safety/index.rst
Outdated
| Safety specific documentation for Platform is listed here | ||
|
|
||
| .. toctree:: | ||
|
|
There was a problem hiding this comment.
please do not show the content of the documents. I think you need the sphinx instruction :maxdepth: 1 for this.
| requirements/index | ||
| modules/index | ||
| contribute/index | ||
| safety/index |
There was a problem hiding this comment.
Shall we call this "dependability" instead "safety" and add also the security documents in the future?
There was a problem hiding this comment.
My suggestion is to keep safety separated from security
Creates the documents in the safety plan which previously been "Link to WP" and their according status in "automated"
Use the folder structure as in the templates from the process_description. Missing templates for platform levels, are created from the ones from module level.
Resolves: #2501