Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document JSR250 lifecycle support #73

Closed
kwin opened this issue Jan 20, 2023 · 1 comment · Fixed by #175
Closed

Document JSR250 lifecycle support #73

kwin opened this issue Jan 20, 2023 · 1 comment · Fixed by #175

Comments

@kwin
Copy link
Contributor

kwin commented Jan 20, 2023

The readme should be extended to explicitly mention JSR250 lifecycle support as Guice standalone does not support it (google/guice#62 (comment)), but it seems this is supported via https://github.com/eclipse/sisu.inject/blob/a41ab393a0c0e6d8eadf0547763fe80168825b49/org.eclipse.sisu.inject/src/org/eclipse/sisu/bean/LifecycleManager.java.

@cstamas
Copy link
Member

cstamas commented Jan 21, 2023

The whole doco migration is still ahead of us, agreed, and updating it (as it still refers some Nexus events).

Related: cstamas#1 my intent here is to provide sisu "native" annotations for lifecycle, for exact reason to avoid pull in dependencies that would make users assume sisu is more than it does 😄 For example, in case of Maven, I'd convert all uses of JSR250 into sisu private annotations, making clear that use of sisu lifecycle is internal detail of Maven alone, it does not provide full CDI functionality or such. Other nice thing would be to stop proliferating (somewhat fixed with https://issues.apache.org/jira/browse/MNG-7045) unwanted dependencies to plugin and extension realms...

In short: I'd avoid calling this JSR250 Lifecycle, but rather Sisu Lifecycle (that MAY support JSR250 if needed -- according to my PR above, will support if annos present, but will STILL WORK if only sisu annos used and LifecycleModule installed).

kwin added a commit that referenced this issue Sep 23, 2024
@kwin kwin closed this as completed in #175 Sep 23, 2024
kwin added a commit that referenced this issue Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants