Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rest): Added endpoint url for summary and administration page info #1895

Merged
merged 1 commit into from
Jun 23, 2023
Merged

fix(rest): Added endpoint url for summary and administration page info #1895

merged 1 commit into from
Jun 23, 2023

Conversation

nikkuma7
Copy link
Contributor

@nikkuma7 nikkuma7 commented Apr 5, 2023

Please provide a summary of your changes here.
I have created a new endpoint URL for summary and administrative page info.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?

Issue: #1894

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

resource/api/projects/{id}/summary/administration
ex: resource/api/projects/c109935d14e846c4afe03a8f3e97798b/summary/administration

How should these changes be tested by the reviewer?
Have you implemented any additional tests?

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@ag4ums ag4ums added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for New-UI Level for the API and UI level changes for the new-ui REST labels Apr 12, 2023
@rudra-superrr rudra-superrr self-assigned this Apr 13, 2023
@rudra-superrr
Copy link
Contributor

Following fields were not present in api response structure:

  • modifiedOn
  • modifiedBy
  • extUrls
  • group
  • LeadArch
  • Mods
  • Contributor
  • vendor shortname
  • vendor url
  • ClearingDetails
  • Clearingteam
  • DeadlineforPreEvaluation
  • LicenseInfoHeader

@nikkuma7 nikkuma7 force-pushed the fix/summaryandadministrativeInfo branch from 281d7c6 to c65e4a5 Compare April 28, 2023 10:11
@rudra-superrr
Copy link
Contributor

Still some of the fields are missing from the above mentioned list.
Also there are extra information like linked projects, linked releases which are of no use for this endpoint.

@nikkuma7 nikkuma7 force-pushed the fix/summaryandadministrativeInfo branch 2 times, most recently from 2c195a6 to 0c7d9de Compare May 9, 2023 05:54
@nikkuma7 nikkuma7 force-pushed the fix/summaryandadministrativeInfo branch from 0c7d9de to 2736e30 Compare May 26, 2023 07:09
@rudra-superrr
Copy link
Contributor

rudra-superrr commented May 26, 2023 •
edited
Loading

Hi @nikkuma7 , rest api docs are broken.
Limited endpoints are getting shown.

@nikkuma7 nikkuma7 force-pushed the fix/summaryandadministrativeInfo branch from 2736e30 to 401e6c0 Compare June 1, 2023 03:38
@rudra-superrr
Copy link
Contributor

Some of the vendor fields are missing and please check the rest api docs again.

@nikkuma7 nikkuma7 force-pushed the fix/summaryandadministrativeInfo branch from 401e6c0 to af669c0 Compare June 1, 2023 07:17
@nikkuma7
Copy link
Contributor Author

nikkuma7 commented Jun 1, 2023

Some of the vendor fields are missing and please check the rest api docs again.

done.

@rudra-superrr
Copy link
Contributor

Testing was successful.
All fields are available except Clearing Details in administration page.

@rudra-superrr rudra-superrr removed the needs general test This is general testing, meaning that there is no org specific issue to check for label Jun 5, 2023
@nikkuma7 nikkuma7 force-pushed the fix/summaryandadministrativeInfo branch 4 times, most recently from d896e9e to ea441b3 Compare June 21, 2023 15:24
rudra-superrr
rudra-superrr reviewed Jun 22, 2023
View reviewed changes
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/ProjectController.java Outdated
return new ResponseEntity<>(userHalResource, HttpStatus.OK);
}

private HalResource<Project> createHalSummaryAdministration(Project sw360Project, User sw360User) throws TException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createHalSummaryAdministration and createHalProject seems to be similar methods, can you try to reuse createHalProject instead of creating a new method with similar functionality.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes done.

fix(rest): Added endpoint url for summary and administration page info
9d79b28 
Signed-off-by: Nikesh kumar <kumar.nikesh@simens.com>
@nikkuma7 nikkuma7 force-pushed the fix/summaryandadministrativeInfo branch from ea441b3 to 9d79b28 Compare June 22, 2023 10:04
@rudra-superrr
Copy link
Contributor

Code looks good.

@rudra-superrr rudra-superrr added ready ready to merge and removed needs code review labels Jun 23, 2023
@ag4ums ag4ums merged commit ff4e370 into eclipse-sw360:main Jun 23, 2023
keerthi-bl pushed a commit to siemens/sw360 that referenced this pull request Jun 26, 2023
@ag4ums @keerthi-bl
Merge pull request eclipse-sw360#1895 from siemens/fix/summaryandadmi…
4cd6d24 
…nistrativeInfo

fix(rest): Added endpoint url for summary and administration page info

Reviewed by: rudra.chopra@siemens.com
Tested by: rudra.chopra@siemens.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudra-superrr rudra-superrr rudra-superrr left review comments

Assignees

@rudra-superrr rudra-superrr

Labels
New-UI Level for the API and UI level changes for the new-ui ready ready to merge REST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikkuma7 @rudra-superrr @ag4ums