Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ECC):Added pagination to ECC release list #1986

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

eldrin30
Copy link
Contributor

@eldrin30 eldrin30 commented Jun 2, 2023

Please provide a summary of your changes here.
Added pagination code so that release list are loaded 10 at a time on the ECC portlet

Suggest Reviewer

You can suggest reviewers here with an @ag4ums .

How To Test?

Have a lot of releases (>1000) and then click on ECC portlet

@ag4ums ag4ums added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Jun 3, 2023
Copy link
Contributor

@smrutis1 smrutis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested

return releaseList;
}

public static String nullToEmptyString(Object in) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the existing method from CommonUtils

@@ -24,6 +24,25 @@
import java.util.Collections;
import java.util.List;

import com.liferay.portal.kernel.json.JSONArray;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-arrange the imports

@nikkuma7
Copy link
Contributor

nikkuma7 commented Jun 8, 2023

image
Data is not loading due to timeout.

@eldrin30
Copy link
Contributor Author

eldrin30 commented Jun 9, 2023

Capture
There was some server and indexing issue earlier, but now its working

@nikkuma7
Copy link
Contributor

Test successful.

Copy link
Contributor

@smrutis1 smrutis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@smrutis1 smrutis1 added ready ready to merge and removed needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Jun 19, 2023
@ag4ums ag4ums merged commit eb8e443 into eclipse-sw360:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants