-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ECC):Added pagination to ECC release list #1986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change requested
return releaseList; | ||
} | ||
|
||
public static String nullToEmptyString(Object in) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the existing method from CommonUtils
@@ -24,6 +24,25 @@ | |||
import java.util.Collections; | |||
import java.util.List; | |||
|
|||
import com.liferay.portal.kernel.json.JSONArray; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-arrange the imports
b061102
to
41c782b
Compare
41c782b
to
edb1555
Compare
edb1555
to
4101849
Compare
Test successful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.
Suggest Reviewer
How To Test?
Have a lot of releases (>1000) and then click on ECC portlet