Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rest): Added businessunit field in usedBy project api. #2003

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix(rest): Added businessunit field in usedBy project api. #2003

merged 1 commit into from
Jul 11, 2023

Conversation

nikkuma7
Copy link
Contributor

@nikkuma7 nikkuma7 commented Jun 15, 2023 •
edited
Loading

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?

Issue: #2031
I have created a new endpoint URL for usedBy project in project summary tab.

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

URL: http://localhost:8080/resource/api/projects/{id}/usedByProject

image

How should these changes be tested by the reviewer?
Have you implemented any additional tests?

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

ag4ums
ag4ums reviewed Jun 23, 2023
View reviewed changes
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/ProjectController.java Outdated
@@ -1227,4 +1228,27 @@ public void getUserProjectCount(HttpServletResponse response) throws TException
throw new SW360Exception(e.getMessage());
}
}
@RequestMapping(value = PROJECTS_URL + "/{id}/showChildProject", method = RequestMethod.GET)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Disussion, endpint should be similar to componet endpoit https://sw360.siemens.com/resource/docs/api-guide.html#resources-component-usedby-list

@nikkuma7 nikkuma7 force-pushed the fix/showLinkedProject branch 2 times, most recently from d79ec4e to 59fbc5e Compare July 3, 2023 11:00
@rudra-superrr rudra-superrr added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for and removed has merge conflicts labels Jul 3, 2023
@rudra-superrr
Copy link
Contributor

Rest Doc for this endpoint is broken.

image

@nikkuma7
Copy link
Contributor Author

nikkuma7 commented Jul 5, 2023

done.
image

@nikkuma7 nikkuma7 changed the title fix(rest): show linked project in project summay tab fix(rest): show usedBy project in project summay tab Jul 5, 2023
@rudra-superrr
Copy link
Contributor

Hi @nikkuma7 ,
We already have an endpoint for usedBy projects, https://sw360.siemens.com/resource/docs/api-guide.html#resources-project-usedby-list

fix(rest): show linked project in project summay tab
f29de2b 
Signed-off-by: Nikesh kumar <kumar.nikesh@simens.com>
@nikkuma7 nikkuma7 changed the title fix(rest): show usedBy project in project summay tab fix(rest): Added businessunit field in usedBy project api. Jul 10, 2023
@nikkuma7
Copy link
Contributor Author

Hi @rudra-superrr ,
We already have an endpoint for usedBy projects, https://sw360.siemens.com/resource/docs/api-guide.html#resources-project-usedby-list, only I add bussinessUnit field, which is required for UI.

URL: http://localhost:8080/resource/api/projects/usedBy/{id}
image

@rudra-superrr
Copy link
Contributor

Changes looks good.

@rudra-superrr rudra-superrr added ready ready to merge and removed needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Jul 10, 2023
@ag4ums ag4ums merged commit 32777c5 into eclipse-sw360:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ag4ums ag4ums ag4ums left review comments

Assignees
No one assigned
Labels
ready ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikkuma7 @rudra-superrr @ag4ums