Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ProjectObligationsEdit): Save comment and status fields on edit #2020

Merged
merged 1 commit into from
Jul 17, 2023
Merged

feat(ProjectObligationsEdit): Save comment and status fields on edit #2020

merged 1 commit into from
Jul 17, 2023

Conversation

afsahsyeda
Copy link
Contributor

Description:

  1. The comment and status fields of License Obligations in a project will be saved on editing.
  2. On change in these 2 fields, their data is stored in the local storage which is then restored back on re-opening the edit page.
  3. The local storage is clearing on submitting the project edit form.

Issue: #2004

Screenshot:
image

@afsahsyeda afsahsyeda added the enhancement New feature or request label Jun 28, 2023
@ag4ums ag4ums added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Jun 30, 2023
@nikkuma7
Copy link
Contributor

nikkuma7 commented Jul 6, 2023

Test successful.
image
Uploading image.png…

@afsahsyeda afsahsyeda force-pushed the feat/AutoSaveObligationsEdit-2004 branch from 5ecf070 to b95bb4d Compare July 7, 2023 10:05
rudra-superrr
rudra-superrr reviewed Jul 10, 2023
View reviewed changes
...t/src/main/resources/META-INF/resources/html/projects/includes/projects/obligationsEdit.jspf Outdated
}
});

function saveStatusAndObl(thisObj) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the method name to saveStatusAndComment as this method is used to save these 2 fields of obligation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have made the changes. Please have a look.

@afsahsyeda afsahsyeda force-pushed the feat/AutoSaveObligationsEdit-2004 branch from b95bb4d to f2ba0b8 Compare July 12, 2023 07:24
feat(ProjectObligationsEdit): Save comment and status fields on edit
b774090 
Signed-off-by: afsahsyeda <afsah.syeda@siemens-healhtineers.com>
@afsahsyeda afsahsyeda force-pushed the feat/AutoSaveObligationsEdit-2004 branch from f2ba0b8 to b774090 Compare July 12, 2023 07:25
@rudra-superrr
Copy link
Contributor

code looks good.

@rudra-superrr rudra-superrr added ready ready to merge and removed needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Jul 13, 2023
@ag4ums ag4ums merged commit f36ef94 into eclipse-sw360:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudra-superrr rudra-superrr rudra-superrr left review comments

Assignees
No one assigned
Labels
enhancement New feature or request ready ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afsahsyeda @nikkuma7 @rudra-superrr @ag4ums