Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest) asynchronous end point for downloading reports. #2032

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

keerthi-bl
Copy link
Contributor

Please provide a summary of your changes here.

  • Did you add or update any new dependencies that are required for your change?
    No

Issue:

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

How should these changes be tested by the reviewer?

Use postman for testing.

Sample URL :
http://localhost:8080/resource/api/reports?withlinkedreleases=true&mimetype=xlsx&mailrequest=true&module=components

Sample response:

{
"response": "E-mail sent succesfully to the end user.",
"url": "http://127.0.0.1:8080/resource/api/reports/download?user=keerthi.bl@sw360.org&module=components&extendedByReleases=true&token=/tmp/keerthi.bl@sw360.org/2023-05-17_a990c489-acf8-4600-911c-2d89015b8bba"
}

Have you implemented any additional tests?

No

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@keerthi-bl
Copy link
Contributor Author

It can be merged only after #1965 . Since its a depended API.

@keerthi-bl keerthi-bl force-pushed the fix/asynchronousapiforreports branch 3 times, most recently from 982765a to ee3b03b Compare July 19, 2023 06:12
@keerthi-bl
Copy link
Contributor Author

Rebase completed

@ag4ums ag4ums added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for and removed has merge conflicts labels Jul 19, 2023
@ag4ums ag4ums requested a review from KoukiHama July 19, 2023 08:05
@keerthi-bl keerthi-bl force-pushed the fix/asynchronousapiforreports branch from ee3b03b to 080a22b Compare July 24, 2023 09:11
@keerthi-bl
Copy link
Contributor Author

Resolved review comments.

Signed-off-by: Keerthi B L <keerthi.bl@siemens.com>
@hoangnt2
Copy link
Contributor

hoangnt2 commented Aug 1, 2023

Look good

@rudra-superrr
Copy link
Contributor

Testing was successful.

@rudra-superrr rudra-superrr added ready ready to merge and removed needs general test This is general testing, meaning that there is no org specific issue to check for labels Aug 10, 2023
@ag4ums ag4ums merged commit c6bf268 into eclipse-sw360:main Aug 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants