Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rel-18.1): changing files for tagging 18.1 #2257

Merged
merged 1 commit into from
May 29, 2024

Conversation

ag4ums
Copy link
Contributor

@ag4ums ag4ums commented Jan 3, 2024

Please provide a summary of your changes here.
release 18.1.0

Issue:

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

How should these changes be tested by the reviewer?
Have you implemented any additional tests?

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@KoukiHama
Copy link
Member

@tienlee Could you also check it?

@KoukiHama
Copy link
Member

KoukiHama commented Jan 5, 2024

Sorry, I have forgot these issue.
#2252 #2251 #2250

We can release this PR for 18.1.
How about releasing 18.2 with the following fixes and merge?
#2252 #2251 #2250

@tienlee
Copy link
Contributor

tienlee commented Jan 5, 2024

All identified bugs on #2219 were fixed. I think we can release a new version (18.1)
Several open issues (#2252, #2250) should be considered to fix after that.

@heliocastro
Copy link
Contributor

#2252 need to be fixed before 18.1.
I'm not keen to see a 18.1.1 released that soon.
Remember, after 18.1, we will move to 18 branch as maintenance branch and then we start to remove liferay ( hooray ) on main.

@KoukiHama
Copy link
Member

KoukiHama commented Jan 5, 2024

#2252 need to be fixed before 18.1.
I'm not keen to see a 18.1.1 released that soon.

OK, @arunazhakesan
Do you have a strategy for how to deal with the following issue about Package Portlet? #2252

@ag4ums
Copy link
Contributor Author

ag4ums commented Jan 7, 2024

I missed #2252, this should be fixed before the release. @arunazhakesan, @afsahsyeda can you please do a hot fix for this issue

@tienlee
Copy link
Contributor

tienlee commented Jan 8, 2024

I missed #2252, this should be fixed before the release. @arunazhakesan, @afsahsyeda can you please do a hot fix for this issue

If you are busy, please assign this issue to me.

@tienlee
Copy link
Contributor

tienlee commented Jan 9, 2024

Issue #2252 was fixed on PR #2262
Please help me to review and check it.

@arunazhakesan
Copy link
Contributor

The group decided to go for this release 18.1.0-M1. Will hold all new PR merges until then.

cc: @ag4ums @KoukiHama @heliocastro

Copy link
Contributor

@smrutis1 smrutis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good

@ag4ums ag4ums force-pushed the chore/release-18.1 branch 2 times, most recently from f9a86ee to 18cb5da Compare May 15, 2024 04:25
Signed-off-by: Anupam Ghosh <ag.4ums@gmail.com>
@ag4ums ag4ums merged commit 20c818a into eclipse-sw360:main May 29, 2024
2 checks passed
keerthi-bl pushed a commit to siemens/sw360 that referenced this pull request Jun 25, 2024
chore(rel-18.1): changing files for tagging 18.1

Reviewed by: smruti.sahoo@siemens.com, kouki1.hama@toshiba.co.jp
@GMishx GMishx deleted the chore/release-18.1 branch October 23, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants