Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): postpone moderation request action #2468

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented May 28, 2024

Description

Update PATCH endpoint for ModerationRequestController to accept POSTPONE as an action from user.

How to test

When the user clicks on "Postpone Request" button from new UI, the moderation request can be patched with action: POSTPONE and new comment updated on the MR.

Closes #2467

@GMishx GMishx added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for REST New-UI Level for the API and UI level changes for the new-ui labels May 28, 2024
@amritkv amritkv self-assigned this Sep 9, 2024
@amritkv
Copy link

amritkv commented Sep 9, 2024

Hi @GMishx !
Checked this PR from POSTMAN UI side. The response is as expected.
But in db, the moderationState is not updating from PENDING to INPROGRESS

Note : Can you please update the response status codes for this postpone request ?

image

Update PATCH endpoint for ModerationRequestController to accept
`POSTPONE` as an action from user.

Signed-off-by: Gaurav Mishra <gmishx@gmail.com>
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
@amritkv
Copy link

amritkv commented Sep 12, 2024

Hi @GMishx !
Its working fine now. 👍🏻
LGTM !

@GMishx GMishx removed the needs general test This is general testing, meaning that there is no org specific issue to check for label Sep 12, 2024
@rudra-superrr rudra-superrr self-assigned this Sep 12, 2024
@rudra-superrr
Copy link
Contributor

Code looks good to me.

@GMishx GMishx added the ready ready to merge label Sep 12, 2024
@GMishx GMishx merged commit 910411f into eclipse-sw360:main Sep 12, 2024
2 checks passed
@GMishx GMishx deleted the feat/mr/postpone branch September 12, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New-UI Level for the API and UI level changes for the new-ui ready ready to merge REST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New endpoint for "Postpone Request" for Moderation Request
3 participants