fix(rest): Added code to get obligation releaseView data in project. #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikkuma7
force-pushed
the
fix/ObligationReleaseView
branch
from
a2e50ff
to
79c984e
Compare
GMishx
added
needs code review
has merge conflicts
needs general test
|
@nikkuma7 please rebase with latest main |
GMishx
requested changes
Aug 16, 2024
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/ProjectController.java
Show resolved
Hide resolved
...-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/Sw360ProjectService.java
Outdated
Show resolved
Hide resolved
nikkuma7
force-pushed
the
fix/ObligationReleaseView
branch
from
79c984e
to
1f2fc57
Compare
Signed-off-by: Nikesh kumar <kumar.nikesh@simens.com>
nikkuma7
force-pushed
the
fix/ObligationReleaseView
branch
from
1f2fc57
to
cd59cd7
Compare
GMishx
reviewed
Sep 12, 2024
| } | ||
| final String releaseId = release.getId(); | ||
|
|
||
| if (approvedCliAttachments.size() == 1) { |
There was a problem hiding this comment.
What will happen if there are more than 1 approved CLI attached? What is expected here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(rest): Added code to get obligation releaseView data in project.
http://localhost:8080/resource/api/projects/{ id}/licenseObligations?view=true
Closes : #2485
Please describe your issue in few words here.
How to reproduce
Describe the bug and list the steps you used when the issue occurred.
Screenshots ( if applicable )
Add screenshots to help explain your problem.
Versions
SW360 logs
docker logs sw360