Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rest): Added code to get obligation releaseView data in project. #2486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(rest): Added code to get obligation releaseView data in project. #2486

wants to merge 1 commit into from

Conversation

nikkuma7
Copy link
Contributor

@nikkuma7 nikkuma7 commented Jun 14, 2024 •
edited
Loading

Description

fix(rest): Added code to get obligation releaseView data in project.

http://localhost:8080/resource/api/projects/{ id}/licenseObligations?view=true

Closes : #2485

Please describe your issue in few words here.

How to reproduce

Describe the bug and list the steps you used when the issue occurred.

Screenshots ( if applicable )

Add screenshots to help explain your problem.

Versions

  • Docker version OR
  • Last commit id on main

SW360 logs

  • With docker through docker logs sw360
  • From bare metal / vm install system under /var/log/sw360/sw360.log and /var/log/tomcat/error.log

@GMishx GMishx added needs code review has merge conflicts needs general test This is general testing, meaning that there is no org specific issue to check for labels Aug 16, 2024
@GMishx
Copy link
Member

GMishx commented Aug 16, 2024

@nikkuma7 please rebase with latest main

@nikkuma7 nikkuma7 force-pushed the fix/ObligationReleaseView branch 2 times, most recently from 1f2fc57 to cd59cd7 Compare September 10, 2024 08:04
GMishx
GMishx previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx
Copy link
Member

GMishx commented Oct 17, 2024

@deo002 please test this PR.

@deo002
Copy link

deo002 commented Oct 22, 2024

status value is null for obligations in response

@nikkuma7 nikkuma7 force-pushed the fix/ObligationReleaseView branch 2 times, most recently from b2861ba to 9549846 Compare October 22, 2024 08:50
@nikkuma7
fix(rest): Added code to get obligation releaseView data in project.
88d100a 
Signed-off-by: Nikesh kumar <kumar.nikesh@siemens.com>
@nikkuma7
Copy link
Contributor Author

status value is null for obligations in response

image

Addressed comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx left review comments

@heliocastro heliocastro Awaiting requested review from heliocastro heliocastro is a code owner

@KoukiHama KoukiHama Awaiting requested review from KoukiHama KoukiHama is a code owner

@arunazhakesan arunazhakesan Awaiting requested review from arunazhakesan arunazhakesan is a code owner

@ag4ums ag4ums Awaiting requested review from ag4ums ag4ums is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@deo002 deo002

Labels
needs general test This is general testing, meaning that there is no org specific issue to check for
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(rest): Added code to get obligation releaseView data in project.
3 participants
@nikkuma7 @GMishx @deo002