Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rest): Ensure visibility field is case-insensitive #2570

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix(rest): Ensure visibility field is case-insensitive #2570

merged 1 commit into from
Sep 12, 2024

Conversation

nikkuma7
Copy link

@nikkuma7 nikkuma7 commented Aug 22, 2024 •
edited
Loading

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?

Issue: Closes : #2569

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

1: URL: http://localhost:8080/resource/api/projects (post)
2: Include the visibility field in the request body.
3: Set the visibility field to both uppercase (e.g., "PRIVATE") and lowercase (e.g., "private").

Uploading image.png…

How should these changes be tested by the reviewer?
Have you implemented any additional tests?

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@nikkuma7 nikkuma7 added needs general test This is general testing, meaning that there is no org specific issue to check for needs code review labels Aug 22, 2024
@GMishx GMishx self-requested a review August 28, 2024 09:14
GMishx
GMishx requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change needed.

...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/ProjectController.java Outdated Show resolved Hide resolved
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/ProjectController.java Show resolved Hide resolved
@nikkuma7 nikkuma7 force-pushed the fix/project-visibility-insensitive branch from 256bcb5 to 0c543ac Compare September 9, 2024 07:42
fix(rest): Ensure visibility field is case-insensitive
d6f6300 
Signed-off-by: Nikesh kumar <kumar.nikesh@simens.com>
@nikkuma7 nikkuma7 force-pushed the fix/project-visibility-insensitive branch from 0c543ac to d6f6300 Compare September 10, 2024 04:03
GMishx
GMishx approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

GMishx
GMishx approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx added ready ready to merge and removed needs general test This is general testing, meaning that there is no org specific issue to check for labels Sep 12, 2024
@GMishx GMishx merged commit 3403285 into eclipse-sw360:main Sep 12, 2024
1 of 2 checks passed
@GMishx GMishx deleted the fix/project-visibility-insensitive branch September 12, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

Assignees
No one assigned
Labels
ready ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(rest): Ensure visibility field is case-insensitive
2 participants
@nikkuma7 @GMishx