Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest): Endpoint to get comments of a Clearing Request. #2603

Merged

Conversation

akshitjoshii
Copy link
Contributor

Get endpoint to fetch paginated comments of a clearing request. If not pagination parameter is passed comments will sorted in descending order by default.

http://localhost:8080/resource/api/clearingrequest/{crId}/comments

image

Signed-off-by: Akshit Joshi <akshit.joshi@siemens-healthineers.com>
@GMishx GMishx added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Sep 9, 2024
@rudra-superrr rudra-superrr self-assigned this Sep 11, 2024
@GMishx
Copy link
Member

GMishx commented Sep 11, 2024

@amritkv can you please test this branch?

@amritkv
Copy link

amritkv commented Sep 11, 2024

clearingrequest/{crId}/comments

Hi @GMishx @akshitjoshii !

I have tested this branch from postman. It is working as expected. 👍🏻

@GMishx GMishx removed the needs general test This is general testing, meaning that there is no org specific issue to check for label Sep 12, 2024
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx GMishx added ready ready to merge and removed needs code review labels Sep 12, 2024
@GMishx GMishx merged commit 8cceaae into eclipse-sw360:main Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a new endpoint to get comments of a particular CR for the new UI.
4 participants