Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripts to work with 1.39 and earlier Theia releases #170 #172

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

jfaltermeier
Copy link
Contributor

  • rebuild needs to be run performed before build

Steps to reproduce issues with released version of generator

mkdir my-extension-38 && cd my-extension-38
yo theia-extension -t 1.38.0
<Enter> (Hello World extension type)
<Enter> (hello-world extension name)
yarn start:browser
yarn start:electron

mkdir my-extension-39 && cd my-extension-39
yo theia-extension -t 1.39.0
<Enter> (Hello World extension type)
<Enter> (hello-world extension name)
yarn start:browser
yarn start:electron

Steps to test including fixes in this PR:

mkdir my-extension-38 && cd my-extension-38
yo theia-extension -t 1.38.0
<Enter> (Hello World extension type)
<Enter> (hello-world extension name)
yarn build:browser
yarn start:browser
yarn build:electron
yarn start:electron

mkdir my-extension-39 && cd my-extension-39
yo theia-extension -t 1.39.0
<Enter> (Hello World extension type)
<Enter> (hello-world extension name)
yarn build:browser
yarn start:browser
yarn build:electron
yarn start:electron

* rebuild needs to be run performed before build
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the updated instructions work as expected 👍

@jfaltermeier jfaltermeier merged commit 20a970e into master Jul 19, 2023
3 checks passed
@jfaltermeier jfaltermeier deleted the jf/issue-170 branch July 19, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants