Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-editor: add missing jsonforms peer dependencies #174

Merged

Conversation

lucas-koehler
Copy link
Contributor

The tree editor framework was updated to require jsonforms as peer dependencies instead of direct dependencies. Thus, they were no longer installed. This commit adds them to the generated tree extension.

See also eclipse-emfcloud/theia-tree-editor#78

Contributed on behalf of STMicroelectronics

The tree editor framework was updated to require jsonforms as peer dependencies instead of direct dependencies.
Thus, they were no longer installed. This commit adds them to the generated tree extension.

See also eclipse-emfcloud/theia-tree-editor#78

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I confirmed the bug on master, and that the changes (using npm link) works as expected.

@vince-fugnitto
Copy link
Member

I'll merge so I can make a release with #173 too.

@vince-fugnitto vince-fugnitto merged commit a135b12 into eclipse-theia:master Aug 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants