bumped yeoman version to "^5.0.0", solves #182 #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sailingKieler
force-pushed
the
bump-yeoman-version
branch
from
67ba5c2
to
b08ebd1
Compare
|
Great! I will test once the build succeeds! |
sailingKieler
force-pushed
the
bump-yeoman-version
branch
from
b08ebd1
to
1b69431
Compare
|
@JonasHelming We need another build, a detail in yarn's handling of peer dependencies apparently hit me, and I didn't run the tests locally (on gitpod). I wasn't aware that the build needs a committer's approval. |
|
I already approved :-) |
* related refinements in the 'TheiaExtension' generator * added launch config for debugging the generator * tested with yo@4 and yo@5 Signed-off-by: Christian Schneider <christian.schneider@typefox.io>
sailingKieler
force-pushed
the
bump-yeoman-version
branch
from
1b69431
to
62fad9f
Compare
|
🎉 🚀 |
|
I spent additional time to convert the generator into an ESM package, and upgraded the version ^6.0.0 (just about to test with ^7.0.0). Are you guys interested in this addition upgrade? |
|
LGTM and works |
JonasHelming
approved these changes
Dec 5, 2023
|
@vince-fugnitto I believe this with #184 would justify a new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JonasHelming What do you think?