Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node 18 #232

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Update to Node 18 #232

merged 2 commits into from
Oct 16, 2024

Conversation

JonasHelming
Copy link
Contributor

No description provided.

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should not contain any yarn.lock change as we do not adapt any dependencies. Can you remove them? When I execute yarn all these changes are reverted again.

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@JonasHelming
Copy link
Contributor Author

@sdirix I also execited yarn again, but still have two changes in the yarn.lock Any idea?

@@ -1671,7 +1671,7 @@ glob@^10.2.2:

glob@^10.3.7:
version "10.4.5"
resolved "https://registry.yarnpkg.com/glob/-/glob-10.4.5.tgz#f4d9f0b90ffdbab09c9d77f5f29b4262517b0956"
resolved "https://registry.npmjs.org/glob/-/glob-10.4.5.tgz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not sure where these changes are coming from, however these are fine

@JonasHelming JonasHelming merged commit 7915ee8 into master Oct 16, 2024
4 checks passed
@sdirix sdirix deleted the GH-231 branch October 16, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants