Move custom resource definitions to separate helm chart #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks, I've verified the approach with the following steps:
- Removed
v7betadummy change in CRD - Used terraform test-configuration to setup minikube and install theia-cloud-base
- Used
helm install -n theiacloud theia-cloud-crds .to install CRDs - Continue with terraform test-configuration to install theia-cloud chart
- Verified Theia Cloud working
- Readded
v7betadummy change in CRD and updated chart version - Used
helm upgrade -n theiacloud theia-cloud-crds . - CRD upgrade worked. Theia Cloud crashed, as expected, because it does not know about v7beta yet
So this looks really promising.
In order to merge it early, we should
- update the Chart.yaml's description, version, appVersion
- Remove the v7beta change
- Update the terraform configurations in the main repository to install the CRDs via this chart (if you want, I can adjust the terraform configs, just let me know)
|
Thanks for the fast review. I updated the chart information and removed the v7beta change. I will also adjust the terraform configurations on the main repository and update the documentation aswell. |
sgraband
added a commit
to eclipse-theia/theia-cloud
that referenced
this pull request
Jul 31, 2023
|
Created the main repo PR: eclipse-theia/theia-cloud#213 |
jfaltermeier
reviewed
Aug 1, 2023
Co-authored-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
jfaltermeier
added a commit
to eclipse-theia/theia-cloud
that referenced
this pull request
Aug 1, 2023
jfaltermeier
approved these changes
Aug 1, 2023
jfaltermeier
pushed a commit
to eclipse-theia/theia-cloud
that referenced
this pull request
Aug 1, 2023
jfaltermeier
added a commit
to eclipse-theia/theia-cloud
that referenced
this pull request
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.