Fix issue terraform scripts not working on windows #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfaltermeier
requested changes
Sep 8, 2023
There was a problem hiding this comment.
Hi, thank you very much for the contribution. Unfortunately the sh on linux behaves different than cmd on windows, so the changes don't work on my system.
I've made a suggestion where we check whether the file path starts with /. If so we add the single quotes, otherwise we don't use quotes. I would guess that a windows path will start with something like C:. Could you please test if this works for you as well?
Co-authored-by: dmm9 <dmm9@users.noreply.github.com>
jfaltermeier
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theia-cloud does not work on Windows out-of-the-box. Probably due to the fact that the local installation of terraform uses cmd.exe under the hoods. There are 2 issues:
--type='json'--> Single or double quotes cause an error. Removing the quotes works on windows.-p '[{ \"...--> Also the initial quotes and escaped quotes cause issues. I tried several combinations with no success. The only way I have found is to extract the patch to a local variable.I didn't test in linux, I hope the CI tests it. Otherwise please test with linux before merging.