Update fabric8 kubernetes client, quarkus, and CRD Versioning #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfaltermeier
force-pushed
the
jf/crd-version
branch
from
b41d8e0
to
430b4df
Compare
* Rename CRDS versions from vXbeta to v1betaX. * Provide Hub for CRs - this is a subset of all fields across versions Contributed on behalf of STMicroelectronics Co-authored-by: Simon Graband <sgraband@eclipsesource.com>
jfaltermeier
force-pushed
the
jf/crd-version
branch
from
430b4df
to
1483599
Compare
sgraband
reviewed
Jan 9, 2024
There was a problem hiding this comment.
Looks good to me 👍 I didn't test the changes, but will do an integration test before merging this PR that updates the values. I would like to fix the demos beforehand as well.
One thing: Could you please update the changelog with the changes here and add the Contributed by tag there as well?
Contributed on behalf of STMicroelectronics
jfaltermeier
force-pushed
the
jf/crd-version
branch
from
8d2d9bd
to
f3ee7de
Compare
👍 I've added an additional commit: https://github.com/eclipsesource/theia-cloud/blob/jf/crd-version/CHANGELOG.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributed on behalf of STMicroelectronics